Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Unified Diff: mojo/shell/incoming_connection_listener_unittest.cc

Issue 667223002: Mojo: More virtual/override style fixes in mojo/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/shell/external_application_registrar_connection.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/shell/incoming_connection_listener_unittest.cc
diff --git a/mojo/shell/incoming_connection_listener_unittest.cc b/mojo/shell/incoming_connection_listener_unittest.cc
index 5488c98591b2ebee3ca82660c4f129e64ae8d876..61b0a5e71ddb1479c070ff81044da37f9124edbf 100644
--- a/mojo/shell/incoming_connection_listener_unittest.cc
+++ b/mojo/shell/incoming_connection_listener_unittest.cc
@@ -25,10 +25,10 @@ namespace {
class TestDelegate : public IncomingConnectionListenerPosix::Delegate {
public:
TestDelegate() {}
- virtual ~TestDelegate() {}
+ ~TestDelegate() override {}
- virtual void OnListening(int rv) override { EXPECT_EQ(net::OK, rv); }
- virtual void OnConnection(net::SocketDescriptor incoming) override {
+ void OnListening(int rv) override { EXPECT_EQ(net::OK, rv); }
+ void OnConnection(net::SocketDescriptor incoming) override {
EXPECT_NE(net::kInvalidSocket, incoming);
}
};
@@ -38,10 +38,10 @@ class ListeningFailsDelegate
: public IncomingConnectionListenerPosix::Delegate {
public:
explicit ListeningFailsDelegate(int expected) : expected_error_(expected) {}
- virtual ~ListeningFailsDelegate() {}
+ ~ListeningFailsDelegate() override {}
- virtual void OnListening(int rv) override { EXPECT_EQ(expected_error_, rv); }
- virtual void OnConnection(net::SocketDescriptor incoming) override {
+ void OnListening(int rv) override { EXPECT_EQ(expected_error_, rv); }
+ void OnConnection(net::SocketDescriptor incoming) override {
FAIL() << "No connection should be attempted.";
}
« no previous file with comments | « mojo/shell/external_application_registrar_connection.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698