Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 6672044: [Isolates] Fix debugger and termination APIs callable from other threads. (Closed)

Created:
9 years, 9 months ago by Mads Ager (chromium)
Modified:
9 years, 7 months ago
Reviewers:
Vitaly Repeshko
CC:
v8-dev
Visibility:
Public.

Description

[Isolates] Fix debugger and termination APIs callable from other threads. A couple of debugger methods and one of the execution termination methods can be called from any thread. If they do not supply an isolate, use the default isolate. This ensures backwards compatibility and gives the possibility of specifying an isolate. R=vitalyr@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=7208

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -25 lines) Patch
M include/v8.h View 1 1 chunk +6 lines, -2 lines 0 comments Download
M include/v8-debug.h View 1 2 chunks +18 lines, -12 lines 0 comments Download
M src/api.cc View 2 chunks +30 lines, -11 lines 0 comments Download
M src/isolate.h View 1 chunk +8 lines, -0 lines 0 comments Download
M src/isolate.cc View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mads Ager (chromium)
9 years, 9 months ago (2011-03-16 14:43:47 UTC) #1
Vitaly Repeshko
LGTM http://codereview.chromium.org/6672044/diff/1/include/v8-debug.h File include/v8-debug.h (right): http://codereview.chromium.org/6672044/diff/1/include/v8-debug.h#newcode257 include/v8-debug.h:257: static void DebugBreak(Isolate* isolate = NULL); Please document ...
9 years, 9 months ago (2011-03-16 18:08:21 UTC) #2
Mads Ager (chromium)
9 years, 9 months ago (2011-03-16 18:52:47 UTC) #3
http://codereview.chromium.org/6672044/diff/1/include/v8-debug.h
File include/v8-debug.h (right):

http://codereview.chromium.org/6672044/diff/1/include/v8-debug.h#newcode257
include/v8-debug.h:257: static void DebugBreak(Isolate* isolate = NULL);
On 2011/03/16 18:08:21, Vitaly Repeshko wrote:
> Please document that these functions use the default isolate if none given.

Done.

http://codereview.chromium.org/6672044/diff/1/include/v8.h
File include/v8.h (right):

http://codereview.chromium.org/6672044/diff/1/include/v8.h#newcode2951
include/v8.h:2951: static void TerminateExecution(Isolate* isolate = NULL);
On 2011/03/16 18:08:21, Vitaly Repeshko wrote:
> Same here.

Done.

Powered by Google App Engine
This is Rietveld 408576698