Issue 6672029: [Isolates] Enter default isolate in initializing API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6672029: [Isolates] Enter default isolate in initializing API. (Closed)

Created:
9 years, 9 months ago by Dmitry Titov

Modified:
9 years, 7 months ago

Reviewers:
Vitaly Repeshko

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/experimental/isolates/

Visibility:
Public.

Description

[Isolates] Enter default isolate in initializing API. Committed: http://code.google.com/p/v8/source/detail?r=7187

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : [Isolates] Enter default isolate in initializing API. #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+91 lines, -10 lines)			Patch
	M	src/api.cc	View	1 2 3	4 chunks	+28 lines, -8 lines	0 comments	Download
	M	test/cctest/test-api.cc	View	1 2 3	3 chunks	+63 lines, -2 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Dmitry Titov

9 years, 9 months ago (2011-03-16 01:25:18 UTC) #1

TBR=vitalyr

Vitaly, sorry for TBR - this would better be reviewed before landing of course.
I'll incorporate all the changes you suggest. (I am trying to clean the way to
run Chromium try bots for all 3 platforms to see if we have more issues.)

This one was breaking workers - in a worker process, the static initializer
thread and subsequent worker threads are different and Chrome was trying to call
things like v8::V8::IgnoreOutOfMemoryException() with NULL in TLS.

We have EnsureInitialized, but it will do complete Setup, which is too early for
at least 3 methods I modified here.

Also changed the test (HugeConsStringOutOfMemory) - it was trying to change heap
size after creating context handle, which simply returns fast. The added ASSERT
in SetResourceConstraints helps to find such misusages.

Expand Messages | Collapse Messages