Add --ssl-version-min and --ssl-version-fallback-min to chrome://flags.

chrome/browser/about_flags.cc

Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index f040401a3f49ea33b8ace1e2c2af85337cb200a7..e3e6d10cc2adcd2de6ed1a175a0fff670bd61f91 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -477,6 +477,31 @@ const Experiment::Choice kAutofillSyncCredentialChoices[] = {
     password_manager::switches::kDisallowAutofillSyncCredential, ""},
 };
 
+const Experiment::Choice kSSLVersionMinChoices[] = {
+  { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
+  { IDS_SSL_VERSION_MIN_SSL3,
+    switches::kSSLVersionMin, "ssl3" },
+  { IDS_SSL_VERSION_MIN_TLS1,
+    switches::kSSLVersionMin, "tls1" },
+  { IDS_SSL_VERSION_MIN_TLS1_1,
+    switches::kSSLVersionMin, "tls1.1" },
+  { IDS_SSL_VERSION_MIN_TLS1_2,
+    switches::kSSLVersionMin, "tls1.2" },
+};
+
+const Experiment::Choice kSSLVersionFallbackMinChoices[] = {
+  { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
+  { IDS_SSL_VERSION_MIN_SSL3,
+    switches::kSSLVersionFallbackMin, "ssl3" },
+  { IDS_SSL_VERSION_MIN_TLS1,
+    switches::kSSLVersionFallbackMin, "tls1" },
+  { IDS_SSL_VERSION_MIN_TLS1_1,
+    switches::kSSLVersionFallbackMin, "tls1.1" },
+  { IDS_SSL_VERSION_MIN_TLS1_2,
+    switches::kSSLVersionFallbackMin, "tls1.2" },
+};
+
+

[Joao da Silva, 2014/10/22 10:49:57]

single newline

[Thiemo Nagel, 2014/10/22 16:30:54]

Thanks.  Done.

 // RECORDING USER METRICS FOR FLAGS:
 // -----------------------------------------------------------------------------
 // The first line of the experiment is the internal name. If you'd like to
@@ -1968,6 +1993,20 @@ const Experiment kExperiments[] = {
     SINGLE_VALUE_TYPE(extensions::switches::kEnableRemoteAssistance)
   },
 #endif  // defined(OS_CHROMEOS)
+  {
+    "ssl-version-min",
+    IDS_FLAGS_SSL_VERSION_MIN_NAME,
+    IDS_FLAGS_SSL_VERSION_MIN_DESCRIPTION,
+    kOsAll,
+    MULTI_VALUE_TYPE(kSSLVersionMinChoices)
+  },
+  {
+    "ssl-version-fallback-min",
+    IDS_FLAGS_SSL_VERSION_FALLBACK_MIN_NAME,
+    IDS_FLAGS_SSL_VERSION_FALLBACK_MIN_DESCRIPTION,
+    kOsAll,
+    MULTI_VALUE_TYPE(kSSLVersionFallbackMinChoices)
+  }
   // NOTE: Adding new command-line switches requires adding corresponding
   // entries to enum "LoginCustomFlags" in histograms.xml. See note in
   // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test.

[Joao da Silva, 2014/10/22 10:49:57]

What about this?

[Thiemo Nagel, 2014/10/22 16:30:54]

Good catch.  I had interpreted that as "upon adding a new command-line switch"
(which wouldn't apply to me), not as "upon new chrome://flags" entry.