Add --ssl-version-min and --ssl-version-fallback-min to chrome://flags.

chrome/browser/about_flags.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/about_flags.h"
 
 #include <iterator>
 #include <map>
 #include <set>
 #include <utility>
@@ skipping 459 matching lines @@
 const Experiment::Choice kAutofillSyncCredentialChoices[] = {
   { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", ""},
   { IDS_ALLOW_AUTOFILL_SYNC_CREDENTIAL,
     password_manager::switches::kAllowAutofillSyncCredential, ""},
   { IDS_DISALLOW_AUTOFILL_SYNC_CREDENTIAL_FOR_REAUTH,
     password_manager::switches::kDisallowAutofillSyncCredentialForReauth, ""},
   { IDS_DISALLOW_AUTOFILL_SYNC_CREDENTIAL,
     password_manager::switches::kDisallowAutofillSyncCredential, ""},
 };
 
+const Experiment::Choice kSSLVersionMinChoices[] = {
+  { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
+  { IDS_SSL_VERSION_MIN_SSL3,
+    switches::kSSLVersionMin, "ssl3" },
+  { IDS_SSL_VERSION_MIN_TLS1,
+    switches::kSSLVersionMin, "tls1" },
+  { IDS_SSL_VERSION_MIN_TLS1_1,
+    switches::kSSLVersionMin, "tls1.1" },
+  { IDS_SSL_VERSION_MIN_TLS1_2,
+    switches::kSSLVersionMin, "tls1.2" },
+};
+
+const Experiment::Choice kSSLVersionFallbackMinChoices[] = {
+  { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
+  { IDS_SSL_VERSION_MIN_SSL3,
+    switches::kSSLVersionFallbackMin, "ssl3" },
+  { IDS_SSL_VERSION_MIN_TLS1,
+    switches::kSSLVersionFallbackMin, "tls1" },
+  { IDS_SSL_VERSION_MIN_TLS1_1,
+    switches::kSSLVersionFallbackMin, "tls1.1" },
+  { IDS_SSL_VERSION_MIN_TLS1_2,
+    switches::kSSLVersionFallbackMin, "tls1.2" },
+};
+
+

[Joao da Silva, 2014/10/22 10:49:57]

single newline

[Thiemo Nagel, 2014/10/22 16:30:54]

Thanks.  Done.

 // RECORDING USER METRICS FOR FLAGS:
 // -----------------------------------------------------------------------------
 // The first line of the experiment is the internal name. If you'd like to
 // gather statistics about the usage of your flag, you should append a marker
 // comment to the end of the feature name, like so:
 //   "my-special-feature",  // FLAGS:RECORD_UMA
 //
 // After doing that, run
 //   tools/metrics/actions/extract_actions.py
 // to add the metric to actions.xml (which will enable UMA to record your
@@ skipping 1471 matching lines @@
 #endif
 #if defined(OS_CHROMEOS)
   {
     "enable-remote-assistance",
     IDS_FLAGS_ENABLE_REMOTE_ASSISTANCE_NAME,
     IDS_FLAGS_ENABLE_REMOTE_ASSISTANCE_DESCRIPTION,
     kOsCrOS,
     SINGLE_VALUE_TYPE(extensions::switches::kEnableRemoteAssistance)
   },
 #endif  // defined(OS_CHROMEOS)
+  {
+    "ssl-version-min",
+    IDS_FLAGS_SSL_VERSION_MIN_NAME,
+    IDS_FLAGS_SSL_VERSION_MIN_DESCRIPTION,
+    kOsAll,
+    MULTI_VALUE_TYPE(kSSLVersionMinChoices)
+  },
+  {
+    "ssl-version-fallback-min",
+    IDS_FLAGS_SSL_VERSION_FALLBACK_MIN_NAME,
+    IDS_FLAGS_SSL_VERSION_FALLBACK_MIN_DESCRIPTION,
+    kOsAll,
+    MULTI_VALUE_TYPE(kSSLVersionFallbackMinChoices)
+  }
   // NOTE: Adding new command-line switches requires adding corresponding
   // entries to enum "LoginCustomFlags" in histograms.xml. See note in
   // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test.

[Joao da Silva, 2014/10/22 10:49:57]

What about this?

[Thiemo Nagel, 2014/10/22 16:30:54]

Good catch.  I had interpreted that as "upon adding a new command-line switch"
(which wouldn't apply to me), not as "upon new chrome://flags" entry.

 };
 
 const Experiment* experiments = kExperiments;
 size_t num_experiments = arraysize(kExperiments);
 
 // Stores and encapsulates the little state that about:flags has.
 class FlagsState {
  public:
   FlagsState() : needs_restart_(false) {}
   void ConvertFlagsToSwitches(FlagsStorage* flags_storage,
@@ skipping 573 matching lines @@
 }
 
 const Experiment* GetExperiments(size_t* count) {
   *count = num_experiments;
   return experiments;
 }
 
 }  // namespace testing
 
 }  // namespace about_flags