Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: extensions/shell/common/shell_extensions_client.h

Issue 667153007: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/shell/common/shell_content_client.h ('k') | extensions/shell/common/shell_extensions_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/shell/common/shell_extensions_client.h
diff --git a/extensions/shell/common/shell_extensions_client.h b/extensions/shell/common/shell_extensions_client.h
index ba9a3309fdd3b0641a09a0b7d05a0f919dd15a61..1b6decec8e23856ed135b8a7f81f8d0ed91a7bfa 100644
--- a/extensions/shell/common/shell_extensions_client.h
+++ b/extensions/shell/common/shell_extensions_client.h
@@ -16,37 +16,34 @@ namespace extensions {
class ShellExtensionsClient : public ExtensionsClient {
public:
ShellExtensionsClient();
- virtual ~ShellExtensionsClient();
+ ~ShellExtensionsClient() override;
// ExtensionsClient overrides:
- virtual void Initialize() override;
- virtual const PermissionMessageProvider& GetPermissionMessageProvider()
+ void Initialize() override;
+ const PermissionMessageProvider& GetPermissionMessageProvider()
const override;
- virtual const std::string GetProductName() override;
- virtual scoped_ptr<FeatureProvider> CreateFeatureProvider(
+ const std::string GetProductName() override;
+ scoped_ptr<FeatureProvider> CreateFeatureProvider(
const std::string& name) const override;
- virtual scoped_ptr<JSONFeatureProviderSource> CreateFeatureProviderSource(
+ scoped_ptr<JSONFeatureProviderSource> CreateFeatureProviderSource(
const std::string& name) const override;
- virtual void FilterHostPermissions(
+ void FilterHostPermissions(
const URLPatternSet& hosts,
URLPatternSet* new_hosts,
std::set<PermissionMessage>* messages) const override;
- virtual void SetScriptingWhitelist(
- const ScriptingWhitelist& whitelist) override;
- virtual const ScriptingWhitelist& GetScriptingWhitelist() const override;
- virtual URLPatternSet GetPermittedChromeSchemeHosts(
+ void SetScriptingWhitelist(const ScriptingWhitelist& whitelist) override;
+ const ScriptingWhitelist& GetScriptingWhitelist() const override;
+ URLPatternSet GetPermittedChromeSchemeHosts(
const Extension* extension,
const APIPermissionSet& api_permissions) const override;
- virtual bool IsScriptableURL(const GURL& url,
- std::string* error) const override;
- virtual bool IsAPISchemaGenerated(const std::string& name) const override;
- virtual base::StringPiece GetAPISchema(
- const std::string& name) const override;
- virtual void RegisterAPISchemaResources(ExtensionAPI* api) const override;
- virtual bool ShouldSuppressFatalErrors() const override;
- virtual std::string GetWebstoreBaseURL() const override;
- virtual std::string GetWebstoreUpdateURL() const override;
- virtual bool IsBlacklistUpdateURL(const GURL& url) const override;
+ bool IsScriptableURL(const GURL& url, std::string* error) const override;
+ bool IsAPISchemaGenerated(const std::string& name) const override;
+ base::StringPiece GetAPISchema(const std::string& name) const override;
+ void RegisterAPISchemaResources(ExtensionAPI* api) const override;
+ bool ShouldSuppressFatalErrors() const override;
+ std::string GetWebstoreBaseURL() const override;
+ std::string GetWebstoreUpdateURL() const override;
+ bool IsBlacklistUpdateURL(const GURL& url) const override;
private:
const ExtensionsAPIPermissions extensions_api_permissions_;
« no previous file with comments | « extensions/shell/common/shell_content_client.h ('k') | extensions/shell/common/shell_extensions_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698