Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Unified Diff: extensions/shell/common/shell_extensions_client.cc

Issue 667153007: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/shell/common/shell_extensions_client.cc
diff --git a/extensions/shell/common/shell_extensions_client.cc b/extensions/shell/common/shell_extensions_client.cc
index 8eae90213be81faa8c28bde2d91a40268fdcba00..4fc57e863fbdbf1c21bde98e9979425e5945feda 100644
--- a/extensions/shell/common/shell_extensions_client.cc
+++ b/extensions/shell/common/shell_extensions_client.cc
@@ -38,31 +38,30 @@ SimpleFeature* CreateFeature() {
class ShellPermissionMessageProvider : public PermissionMessageProvider {
public:
ShellPermissionMessageProvider() {}
- virtual ~ShellPermissionMessageProvider() {}
+ ~ShellPermissionMessageProvider() override {}
// PermissionMessageProvider implementation.
- virtual PermissionMessages GetPermissionMessages(
+ PermissionMessages GetPermissionMessages(
const PermissionSet* permissions,
Manifest::Type extension_type) const override {
return PermissionMessages();
}
- virtual std::vector<base::string16> GetWarningMessages(
+ std::vector<base::string16> GetWarningMessages(
const PermissionSet* permissions,
Manifest::Type extension_type) const override {
return std::vector<base::string16>();
}
- virtual std::vector<base::string16> GetWarningMessagesDetails(
+ std::vector<base::string16> GetWarningMessagesDetails(
const PermissionSet* permissions,
Manifest::Type extension_type) const override {
return std::vector<base::string16>();
}
- virtual bool IsPrivilegeIncrease(
- const PermissionSet* old_permissions,
- const PermissionSet* new_permissions,
- Manifest::Type extension_type) const override {
+ bool IsPrivilegeIncrease(const PermissionSet* old_permissions,
+ const PermissionSet* new_permissions,
+ Manifest::Type extension_type) const override {
// Ensure we implement this before shipping.
CHECK(false);
return false;
« no previous file with comments | « extensions/shell/common/shell_extensions_client.h ('k') | extensions/shell/renderer/shell_content_renderer_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698