Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(633)

Unified Diff: components/autofill/core/browser/autofill_manager.cc

Issue 667043002: Add a flag to ignore autocomplete="off" for Autofill. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git/+/master
Patch Set: better comments Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/autofill_manager.cc
diff --git a/components/autofill/core/browser/autofill_manager.cc b/components/autofill/core/browser/autofill_manager.cc
index 48cd5974c206b50c064630dace3cb85731b24497..42c79266f38acae1ee030928380d5709df675370 100644
--- a/components/autofill/core/browser/autofill_manager.cc
+++ b/components/autofill/core/browser/autofill_manager.cc
@@ -530,12 +530,19 @@ void AutofillManager::OnQueryFormFieldAutofill(int query_id,
}
}
- // Add the results from AutoComplete. They come back asynchronously, so we
- // hand off what we generated and they will send the results back to the
- // renderer.
- autocomplete_history_manager_->OnGetAutocompleteSuggestions(
- query_id, field.name, field.value, field.form_control_type, values,
- labels, icons, unique_ids);
+ if (field.should_autocomplete) {
+ // Add the results from AutoComplete. They come back asynchronously, so we
+ // hand off what we generated and they will send the results back to the
+ // renderer.
+ autocomplete_history_manager_->OnGetAutocompleteSuggestions(
groby-ooo-7-16 2014/10/20 22:52:31 Question: OnGetAutocompleteSuggestions also cancel
Evan Stade 2014/10/20 23:01:54 good call, we should probably do autocomplete_hist
+ query_id, field.name, field.value, field.form_control_type, values,
+ labels, icons, unique_ids);
+ } else {
+ // Autocomplete is disabled for this field; only pass back Autofill
+ // suggestions.
+ external_delegate_->OnSuggestionsReturned(
+ query_id, values, labels, icons, unique_ids);
+ }
}
void AutofillManager::FillOrPreviewForm(

Powered by Google App Engine
This is Rietveld 408576698