Add a flag to ignore autocomplete="off" for Autofill.

components/autofill/core/browser/autofill_manager.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/autofill_manager.h"
 
 #include <stddef.h>
 
 #include <limits>
 #include <map>
@@ skipping 512 matching lines @@
         // The first time we show suggestions on this page, log the number of
         // suggestions shown.
         if (!has_logged_address_suggestions_count_ && !section_is_autofilled) {
           metric_logger_->LogAddressSuggestionsCount(values.size());
           has_logged_address_suggestions_count_ = true;
         }
       }
     }
   }
 
-  // Add the results from AutoComplete.  They come back asynchronously, so we
-  // hand off what we generated and they will send the results back to the
-  // renderer.
-  autocomplete_history_manager_->OnGetAutocompleteSuggestions(
-      query_id, field.name, field.value, field.form_control_type, values,
-      labels, icons, unique_ids);
+  if (field.should_autocomplete) {
+    // Add the results from AutoComplete.  They come back asynchronously, so we
+    // hand off what we generated and they will send the results back to the
+    // renderer.
+    autocomplete_history_manager_->OnGetAutocompleteSuggestions(

[groby-ooo-7-16, 2014/10/20 22:52:31]

Question: OnGetAutocompleteSuggestions also cancels pending queries - is that
important for the "ignore autocomplete" case?

[Evan Stade, 2014/10/20 23:01:54]

good call, we should probably do
autocomplete_history_manager_->CancelPendingQuery() in the !should_autocomplete
case.

+        query_id, field.name, field.value, field.form_control_type, values,
+        labels, icons, unique_ids);
+  } else {
+    // Autocomplete is disabled for this field; only pass back Autofill
+    // suggestions.
+    external_delegate_->OnSuggestionsReturned(
+        query_id, values, labels, icons, unique_ids);
+  }
 }
 
 void AutofillManager::FillOrPreviewForm(
     AutofillDriver::RendererFormDataAction action,
     int query_id,
     const FormData& form,
     const FormFieldData& field,
     int unique_id) {
   if (!IsValidFormData(form) || !IsValidFormFieldData(field))
     return;
@@ skipping 693 matching lines @@
     return false;
 
   // Disregard forms that we wouldn't ever autofill in the first place.
   if (!form.ShouldBeParsed())
     return false;
 
   return true;
 }
 
 }  // namespace autofill