Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: components/autofill/core/browser/autocomplete_history_manager.h

Issue 667043002: Add a flag to ignore autocomplete="off" for Autofill. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git/+/master
Patch Set: fix MSVC error C4373 Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/autocomplete_history_manager.h
diff --git a/components/autofill/core/browser/autocomplete_history_manager.h b/components/autofill/core/browser/autocomplete_history_manager.h
index 254676bb8a620ddf798e9ced326a71208a4921a7..fb5747400cef01de43b41d59c875189821b96689 100644
--- a/components/autofill/core/browser/autocomplete_history_manager.h
+++ b/components/autofill/core/browser/autocomplete_history_manager.h
@@ -26,19 +26,19 @@ class AutocompleteHistoryManager : public WebDataServiceConsumer {
public:
AutocompleteHistoryManager(AutofillDriver* driver,
AutofillClient* autofill_client);
- ~AutocompleteHistoryManager() override;
+ virtual ~AutocompleteHistoryManager() override;
// WebDataServiceConsumer implementation.
- void OnWebDataServiceRequestDone(WebDataServiceBase::Handle h,
- const WDTypedResult* result) override;
+ virtual void OnWebDataServiceRequestDone(
+ WebDataServiceBase::Handle h, const WDTypedResult* result) override;
// Pass-through functions that are called by AutofillManager, after it has
// dispatched a message.
- void OnGetAutocompleteSuggestions(
+ virtual void OnGetAutocompleteSuggestions(
int query_id,
const base::string16& name,
const base::string16& prefix,
- const std::string form_control_type,
+ const std::string& form_control_type,
const std::vector<base::string16>& autofill_values,
const std::vector<base::string16>& autofill_labels,
const std::vector<base::string16>& autofill_icons,

Powered by Google App Engine
This is Rietveld 408576698