components/autofill/core/browser/autocomplete_history_manager.cc - Issue 667043002: Add a flag to ignore autocomplete="off" for Autofill.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autocomplete_history_manager.cc

Issue 667043002: Add a flag to ignore autocomplete="off" for Autofill. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git/+/master

Patch Set: fix MSVC error C4373 Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/browser/autocomplete_history_manager.h ('k') | components/autofill/core/browser/autofill_external_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/autocomplete_history_manager.cc

diff --git a/components/autofill/core/browser/autocomplete_history_manager.cc b/components/autofill/core/browser/autocomplete_history_manager.cc

index d96249b47902241b13def2ddd8f7b9d01ca9b970..5b8bbb48644b12c40c06c7216339a7f4787204a9 100644

--- a/components/autofill/core/browser/autocomplete_history_manager.cc

+++ b/components/autofill/core/browser/autocomplete_history_manager.cc

@@ -87,7 +87,7 @@ void AutocompleteHistoryManager::OnGetAutocompleteSuggestions(

int query_id,

const base::string16& name,

const base::string16& prefix,

- const std::string form_control_type,

+ const std::string& form_control_type,

const std::vector<base::string16>& autofill_values,

const std::vector<base::string16>& autofill_labels,

const std::vector<base::string16>& autofill_icons,