Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(67)

Issue 6670115: Improve property access with keys that can always be converted into a symbol string. (Closed)

Created:
8 years, 1 month ago by fschneider
Modified:
7 years, 11 months ago
CC:
v8-dev
Visibility:
Public.

Description

Improve property access with keys that can always be converted into a symbol string. Committed: http://code.google.com/p/v8/source/detail?r=7454

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M src/heap.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/ic.cc View 1 1 chunk +9 lines, -0 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
fschneider
8 years, 1 month ago (2011-03-31 09:24:45 UTC) #1
Mads Ager (chromium)
8 years, 1 month ago (2011-03-31 09:41:49 UTC) #2
LGTM

http://codereview.chromium.org/6670115/diff/1003/src/ic.cc
File src/ic.cc (right):

http://codereview.chromium.org/6670115/diff/1003/src/ic.cc#newcode1146
src/ic.cc:1146: // Check for values that can be converted into a symbol.
Could you file a bug report stating that this is put in because Kraken 1.1 is
not released in the web runner. Kraken 1.0 accesses undefined and NaN in arrays
a lot and this speeds it up. We have put it in so people do not make wrong
conclusions based on broken benchmarks. Once the web runner is updated to Kraken
1.1 which does correct array accesses we should get rid of this again.

Powered by Google App Engine
This is Rietveld 408576698