runtime/vm/object.h - Issue 666993002: Fix test timeout; faster DEBUG String::CharAt by not using mutable accessor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/object.h

Issue 666993002: Fix test timeout; faster DEBUG String::CharAt by not using mutable accessor. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/object.h

===================================================================

--- runtime/vm/object.h (revision 41200)

+++ runtime/vm/object.h (working copy)

@@ -5841,8 +5841,9 @@

class OneByteString : public AllStatic {

public:

static uint16_t CharAt(const String& str, intptr_t index) {

- NoGCScope no_gc;

- return *CharAddr(str, index);

+ ASSERT((index >= 0) && (index < str.Length()));

+ ASSERT(str.IsOneByteString());

+ return raw_ptr(str)->data()[index];

}

static void SetCharAt(const String& str, intptr_t index, uint8_t code_unit) {

« no previous file with comments | « no previous file | runtime/vm/object.cc » ('j') | no next file with comments »