Issue 666993002: Fix test timeout; faster DEBUG String::CharAt by not using mutable accessor.

Issue 666993002: Fix test timeout; faster DEBUG String::CharAt by not using mutable accessor. (Closed)

Created:
6 years, 2 months ago by koda

Modified:
6 years, 2 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix test timeout; faster DEBUG String::CharAt by not using mutable accessor. BUG=dart:21343 R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=41218

Patch Set 2 : #

Total comments: 4

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -8 lines)			Patch
M	runtime/vm/object.h	View	1 chunk	+3 lines, -2 lines	4 comments	Download
M	runtime/vm/object.cc	View	1 chunk	+4 lines, -5 lines	0 comments	Download
M	tests/language/language.status	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTM -Ivan https://codereview.chromium.org/666993002/diff/20001/runtime/vm/object.h File runtime/vm/object.h (right): https://codereview.chromium.org/666993002/diff/20001/runtime/vm/object.h#newcode5976 runtime/vm/object.h:5976: return *CharAddr(str, index); How about fixing it ...

6 years, 2 months ago (2014-10-20 21:15:10 UTC) #2

koda

https://codereview.chromium.org/666993002/diff/20001/runtime/vm/object.h File runtime/vm/object.h (right): https://codereview.chromium.org/666993002/diff/20001/runtime/vm/object.h#newcode5976 runtime/vm/object.h:5976: return *CharAddr(str, index); On 2014/10/20 21:15:10, Ivan Posva wrote: ...

6 years, 2 months ago (2014-10-20 23:58:28 UTC) #3

koda

Committed patchset #2 (id:20001) manually as r41218 (presubmit successful).

6 years, 2 months ago (2014-10-21 00:15:48 UTC) #4

Florian Schneider

6 years, 2 months ago (2014-10-21 10:03:05 UTC) #5

Message was sent while issue was closed.

On 2014/10/21 00:15:48, koda wrote:
> Committed patchset #2 (id:20001) manually as r41218 (presubmit successful).

dbc:
This reason this test takes so long is the linear search in
Parser::CheckMemberNameConflict.

Expand Messages | Collapse Messages