Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 666943002: Revert of New run shell implementation for DeviceUtils (Closed)

Created:
6 years, 2 months ago by perezju
Modified:
6 years, 2 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of New run shell implementation for DeviceUtils (patchset #8 id:140001 of https://codereview.chromium.org/659533002/) Reason for revert: Broke some telemetry telemetry unittests and perf unittests Original issue's description: > New run shell implementation for DeviceUtils > > The main differences are: > - it uses AdbWrapper.Shell to actually execute the command. > - when the cmd is supplied as a list of a command and its arguments, > the arguments are quoted to prevent them from being (mis)interpreted > by the shell. > - a new single_line option to check that the output produces contains a single line, and return the value of that line. > > BUG=267773 > > Committed: https://crrev.com/ab18bcca0cc1475cf381211e595e75c1146c9115 > Cr-Commit-Position: refs/heads/master@{#300237} TBR=jbudorick@chromium.org NOTREECHECKS=true NOTRY=true BUG=267773 Committed: https://crrev.com/3938cc489efbde98f6cdeae6cb880ef3ef97b66b Cr-Commit-Position: refs/heads/master@{#300258}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+201 lines, -484 lines) Patch
M build/android/pylib/cmd_helper.py View 3 chunks +1 line, -48 lines 0 comments Download
D build/android/pylib/cmd_helper_test.py View 1 chunk +0 lines, -53 lines 0 comments Download
M build/android/pylib/device/adb_wrapper.py View 1 chunk +6 lines, -4 lines 0 comments Download
M build/android/pylib/device/adb_wrapper_test.py View 1 chunk +2 lines, -2 lines 0 comments Download
M build/android/pylib/device/device_errors.py View 1 chunk +1 line, -14 lines 0 comments Download
M build/android/pylib/device/device_utils.py View 13 chunks +63 lines, -115 lines 0 comments Download
M build/android/pylib/device/device_utils_test.py View 10 chunks +124 lines, -244 lines 0 comments Download
M build/android/pylib/instrumentation/test_runner.py View 1 chunk +2 lines, -2 lines 0 comments Download
M build/android/pylib/instrumentation/test_runner_test.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
perezju
Created Revert of New run shell implementation for DeviceUtils
6 years, 2 months ago (2014-10-20 13:15:38 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/666943002/1
6 years, 2 months ago (2014-10-20 13:16:10 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 2 months ago (2014-10-20 13:16:12 UTC) #4
jbudorick
lgtm
6 years, 2 months ago (2014-10-20 13:16:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/666943002/1
6 years, 2 months ago (2014-10-20 13:17:02 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-20 13:17:39 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 13:18:21 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3938cc489efbde98f6cdeae6cb880ef3ef97b66b
Cr-Commit-Position: refs/heads/master@{#300258}

Powered by Google App Engine
This is Rietveld 408576698