build/android/pylib/instrumentation/test_runner.py - Issue 666943002: Revert of New run shell implementation for DeviceUtils

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/instrumentation/test_runner.py

Issue 666943002: Revert of New run shell implementation for DeviceUtils (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/pylib/instrumentation/test_runner.py

diff --git a/build/android/pylib/instrumentation/test_runner.py b/build/android/pylib/instrumentation/test_runner.py

index 821fec1f2a8c28e2d69d8621838149b904808c5b..0e6c168449d122f348663878aa6267401041d73c 100644

--- a/build/android/pylib/instrumentation/test_runner.py

+++ b/build/android/pylib/instrumentation/test_runner.py

@@ -358,8 +358,8 @@

cmd = ['am', 'instrument', '-r']

for k, v in self._GetInstrumentationArgs().iteritems():

- cmd.extend(['-e', k, v])

- cmd.extend(['-e', 'class', test])

+ cmd.extend(['-e', k, "'%s'" % v])

+ cmd.extend(['-e', 'class', "'%s'" % test])

cmd.extend(['-w', instrumentation_path])

return self.device.RunShellCommand(cmd, timeout=timeout, retries=0)

« no previous file with comments | « build/android/pylib/device/device_utils_test.py ('k') | build/android/pylib/instrumentation/test_runner_test.py » ('j') | no next file with comments »