Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 666883002: DevTools: [CSS] cache lineEndings in InspectorStyleSheet (Closed)

Created:
6 years, 2 months ago by lushnikov
Modified:
6 years, 2 months ago
Reviewers:
vsevik, apavlov, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

DevTools: [CSS] cache lineEndings in InspectorStyleSheet lineEndings are used for creation of source range in the protocol CSS domain. This significantly speeds up all CSS domain protocol methods. BUG=423823 R=vsevik, pfeldman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183981

Patch Set 1 #

Patch Set 2 : remove semicolon #

Patch Set 3 : add testcase #

Patch Set 4 : get rid of pointer magic #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -33 lines) Patch
M LayoutTests/http/tests/inspector-enabled/reattach-after-editing-styles.html View 1 2 3 chunks +22 lines, -7 lines 0 comments Download
M LayoutTests/http/tests/inspector-enabled/reattach-after-editing-styles-expected.txt View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorStyleSheet.h View 1 3 chunks +4 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorStyleSheet.cpp View 1 2 3 18 chunks +24 lines, -24 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
lushnikov
PTAL
6 years, 2 months ago (2014-10-20 10:59:35 UTC) #2
vsevik
lgtm
6 years, 2 months ago (2014-10-20 12:09:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/666883002/60001
6 years, 2 months ago (2014-10-20 12:56:54 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 13:56:05 UTC) #6
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as 183981

Powered by Google App Engine
This is Rietveld 408576698