Source/core/inspector/InspectorStyleSheet.h - Issue 666883002: DevTools: [CSS] cache lineEndings in InspectorStyleSheet

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/InspectorStyleSheet.h

Issue 666883002: DevTools: [CSS] cache lineEndings in InspectorStyleSheet (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: get rid of pointer magic Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/inspector-enabled/reattach-after-editing-styles-expected.txt ('k') | Source/core/inspector/InspectorStyleSheet.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/inspector/InspectorStyleSheet.h

diff --git a/Source/core/inspector/InspectorStyleSheet.h b/Source/core/inspector/InspectorStyleSheet.h

index 20d90b71577aeebd7c19c866e17b442225ecf651..03f24a940f9ad581e4c02f601990ac447c8ab7df 100644

--- a/Source/core/inspector/InspectorStyleSheet.h

+++ b/Source/core/inspector/InspectorStyleSheet.h

@@ -54,6 +54,7 @@ class InspectorStyleSheetBase;

typedef WillBeHeapVector<RefPtrWillBeMember<CSSRule> > CSSRuleVector;

typedef String ErrorString;

+typedef Vector<unsigned> LineEndings;

class InspectorCSSId {

public:

@@ -168,8 +169,8 @@ protected:

InspectorStyleSheetBase(const String& id, Listener*);

Listener* listener() const { return m_listener; }

- void fireStyleSheetChanged();

- PassOwnPtr<Vector<unsigned> > lineEndings();

+ void onStyleSheetTextChanged();

+ const LineEndings* lineEndings();

virtual PassRefPtrWillBeRawPtr<InspectorStyle> inspectorStyleForId(const InspectorCSSId&) = 0;

virtual unsigned ruleCount() = 0;

@@ -183,6 +184,7 @@ private:

String m_id;

Listener* m_listener;

+ OwnPtr<LineEndings> m_lineEndings;

};

class InspectorStyleSheet : public InspectorStyleSheetBase {