Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Unified Diff: chrome/android/BUILD.gn

Issue 666813002: GN: Fix Android component build (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn-clank
Patch Set: Actually undo gyp change Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/BUILD.gn
diff --git a/chrome/android/BUILD.gn b/chrome/android/BUILD.gn
index 076e956252802ac3015ca9f4f88efd027f7fb194..365e70ccf4320af439d89ce3ac921f743c148a14 100644
--- a/chrome/android/BUILD.gn
+++ b/chrome/android/BUILD.gn
@@ -206,6 +206,8 @@ static_library("chrome_shell_base") {
"//skia",
]
+ ldflags = [ "-Wl,--gc-sections" ]
+
# TODO(GYP):
#[ 'order_profiling!=0', {
#'conditions': [
@@ -216,24 +218,18 @@ static_library("chrome_shell_base") {
#}],
}
-# TODO(GYP, cjhopman): make chrome_shell_base actually link and then move it to
-# deps. Also, actually compile the main delegates at that point.
# GYP: //chrome/chrome_browser.gypi:libchromeshell
shared_library("chrome_shell") {
testonly = true
sources = [
# This file must always be included in the shared_library step to ensure
# JNI_OnLoad is exported.
-#"//chrome/app/android/chrome_jni_onload.cc",
-#"shell/chrome_main_delegate_chrome_shell_android.cc",
-#"shell/chrome_main_delegate_chrome_shell_android.h",
+ "//chrome/app/android/chrome_jni_onload.cc",
+ "shell/chrome_main_delegate_chrome_shell_android.cc",
+ "shell/chrome_main_delegate_chrome_shell_android.h",
]
deps = [
-#":chrome_shell_base",
- ]
- deps = [ ":chrome_java" ]
- datadeps = [
- ":chrome_shell_base"
+ ":chrome_shell_base",
]
}

Powered by Google App Engine
This is Rietveld 408576698