Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Unified Diff: chrome/browser/sync/glue/browser_thread_model_worker.h

Issue 666733003: Standardize usage of virtual/override/final in chrome/browser/sync/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/browser_thread_model_worker.h
diff --git a/chrome/browser/sync/glue/browser_thread_model_worker.h b/chrome/browser/sync/glue/browser_thread_model_worker.h
index 766576a1cf0a0054c4ecfb13a5f87ebc60a3d420..241f5fcc8cc426ba92462ba66dccb9b130da4da4 100644
--- a/chrome/browser/sync/glue/browser_thread_model_worker.h
+++ b/chrome/browser/sync/glue/browser_thread_model_worker.h
@@ -29,13 +29,13 @@ class BrowserThreadModelWorker : public syncer::ModelSafeWorker {
syncer::WorkerLoopDestructionObserver* observer);
// syncer::ModelSafeWorker implementation. Called on the sync thread.
- virtual void RegisterForLoopDestruction() override;
- virtual syncer::ModelSafeGroup GetModelSafeGroup() override;
+ void RegisterForLoopDestruction() override;
+ syncer::ModelSafeGroup GetModelSafeGroup() override;
protected:
- virtual ~BrowserThreadModelWorker();
+ ~BrowserThreadModelWorker() override;
- virtual syncer::SyncerError DoWorkAndWaitUntilDoneImpl(
+ syncer::SyncerError DoWorkAndWaitUntilDoneImpl(
const syncer::WorkCallback& work) override;
// Marked pure virtual so subclasses have to override, but there is
@@ -61,13 +61,12 @@ class DatabaseModelWorker : public BrowserThreadModelWorker {
explicit DatabaseModelWorker(syncer::WorkerLoopDestructionObserver* observer);
protected:
- virtual void CallDoWorkAndSignalTask(
- const syncer::WorkCallback& work,
- base::WaitableEvent* done,
- syncer::SyncerError* error) override;
+ void CallDoWorkAndSignalTask(const syncer::WorkCallback& work,
+ base::WaitableEvent* done,
+ syncer::SyncerError* error) override;
private:
- virtual ~DatabaseModelWorker();
+ ~DatabaseModelWorker() override;
};
class FileModelWorker : public BrowserThreadModelWorker {
@@ -75,13 +74,12 @@ class FileModelWorker : public BrowserThreadModelWorker {
explicit FileModelWorker(syncer::WorkerLoopDestructionObserver* observer);
protected:
- virtual void CallDoWorkAndSignalTask(
- const syncer::WorkCallback& work,
- base::WaitableEvent* done,
- syncer::SyncerError* error) override;
+ void CallDoWorkAndSignalTask(const syncer::WorkCallback& work,
+ base::WaitableEvent* done,
+ syncer::SyncerError* error) override;
private:
- virtual ~FileModelWorker();
+ ~FileModelWorker() override;
};
} // namespace browser_sync
« no previous file with comments | « chrome/browser/sync/glue/bookmark_model_associator.h ('k') | chrome/browser/sync/glue/extension_backed_data_type_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698