Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: build/common.gypi

Issue 66673005: Build mac and linux release builds with symbols and don't strip them by default (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 820e8e44a2db403cdf31d182c1704c4dbfd8cc78..4072ad56d72a65b8596cbe7e34caec92377a65d4 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -930,7 +930,7 @@
# The default value for mac_strip in target_defaults. This cannot be
# set there, per the comment about variable% in a target_defaults.
- 'mac_strip_release%': 1,
+ 'mac_strip_release%': 0,
# Set to 1 to enable code coverage. In addition to build changes
# (e.g. extra CFLAGS), also creates a new target in the src/chrome
@@ -1022,7 +1022,7 @@
# Enable strict glibc debug mode.
'glibcxx_debug%': 0,
# And if we want to dump symbols for Breakpad-enabled builds.
- 'linux_dump_symbols%': 0,
+ 'linux_dump_symbols%': 1,
# And if we want to strip the binary after dumping symbols.
'linux_strip_binary%': 0,
# Strip the test binaries needed for Linux reliability tests.
@@ -1391,6 +1391,13 @@
['OS=="mac"', {
# Enable clang on mac by default!
'clang%': 1,
+ 'conditions': [
+ # All Chrome builds have breakpad symbols, but only process the
+ # symbols from official builds.
+ ['(branding=="Chrome" and buildtype=="Official")', {
+ 'mac_strip_release%': 1,
+ }],
+ ],
}], # OS=="mac"
['OS=="mac" or OS=="ios"', {
'variables': {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698