Stop fallback for empty local path in ui::SelectedFileInfo's constructor.

Stop fallback for empty local path in ui::SelectedFileInfo's constructor.

Previously ui::SelectedFileInfo's constructor has a fallback to use the file
path instead of an emtpy local path. But this fallback can assign non-native
paths like '/special/drive/xxx' to local_path variable when the file does not
have a snapshot.

The CL removes the fallback, and modify the default behavior of
FileSelectDialog::Lister so that it routes an empty local_path to file_path.

BUG=126902
TEST=manually

Committed: https://crrev.com/5092f4c7e56734679ae69b00ea910898208091a7
Cr-Commit-Position: refs/heads/master@{#300628}

[hirono, 2014-10-20 05:03:07]

hirono@chromium.org changed reviewers:
+ mtomasz@chromium.org

[hirono, 2014-10-20 05:03:07]

PTAL the CL? Thank you!

[mtomasz, 2014-10-20 05:06:14]

On 2014/10/20 05:03:07, hirono wrote:
> PTAL the CL? Thank you!

typo: assums -> assumes

Can't we just remove the fallback from
https://code.google.com/p/chromium/codesearch#chromium/src/ui/shell_dialogs/s...
WDYT?

[hirono, 2014-10-21 02:43:49]

I changed the strategy. Please take another look? Thank you!

[mtomasz, 2014-10-21 02:45:19]

Nice, lgtm!

[hirono, 2014-10-21 02:46:16]

hirono@chromium.org changed reviewers:
+ sky@chromium.org

[hirono, 2014-10-21 02:46:17]

@sky - PTAL? Thank you!

[sky, 2014-10-21 03:19:04]

Did you investigate why the logic was added that you're removed?

[hirono, 2014-10-21 05:07:08]

@sky - The fallback was introduced at the same time when the |local_path|
introduced to the structure.  crrev.com/10804026

According to the code search, all constructor calls other than
"private_api_util.cc" specify the same value for file_path and local_path. For
private_api_util, it specifies an empty local path when the handler specify
support_drive = true is specified. There are a few sub-classes of
FileSelectDialog::Listener that specifies support_drive = true, but all the
sub-classes handle the empty local path correctly or use the default
implementation of FileSelectedWithExtraInfo.

[sky, 2014-10-21 18:01:01]

LGTM

[hirono, 2014-10-22 02:47:48]

On 2014/10/21 18:01:01, sky wrote:
> LGTM

Thanks!

[hirono, 2014-10-22 02:47:51]

The CQ bit was checked by hirono@chromium.org

[commit-bot: I haz the power, 2014-10-22 02:48:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/666693004/60001

[commit-bot: I haz the power, 2014-10-22 04:15:23]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2014-10-22 04:16:25]

Patchset 4 (id:??) landed as
https://crrev.com/5092f4c7e56734679ae69b00ea910898208091a7
Cr-Commit-Position: refs/heads/master@{#300628}