ui/shell_dialogs/selected_file_info.cc - Issue 666693004: Stop fallback for empty local path in ui::SelectedFileInfo's constructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/shell_dialogs/selected_file_info.cc

Issue 666693004: Stop fallback for empty local path in ui::SelectedFileInfo's constructor. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: git cl format Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/shell_dialogs/selected_file_info.cc

diff --git a/ui/shell_dialogs/selected_file_info.cc b/ui/shell_dialogs/selected_file_info.cc

index 8bc68abac70a10bfbad949a4499f23be10199cdc..054c511e81621f7fb64ab47e014924e50e572248 100644

--- a/ui/shell_dialogs/selected_file_info.cc

+++ b/ui/shell_dialogs/selected_file_info.cc

@@ -12,8 +12,6 @@ SelectedFileInfo::SelectedFileInfo(const base::FilePath& in_file_path,

const base::FilePath& in_local_path)

: file_path(in_file_path),

local_path(in_local_path) {

- if (local_path.empty())

- local_path = file_path;

display_name = in_file_path.BaseName().value();

}

« no previous file with comments | « ui/shell_dialogs/selected_file_info.h ('k') | no next file » | no next file with comments »