Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 666653002: Cleanup: Merge device/udev_linux/udev.{cc,h} into device/udev_linux/scoped_udev.h. (Closed)

Created:
6 years, 2 months ago by Lei Zhang
Modified:
6 years, 2 months ago
CC:
chromium-reviews, ozone-reviews_chromium.org, extensions-reviews_chromium.org, tdresser+watch_chromium.org, darin-cc_chromium.org, kalyank, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Merge device/udev_linux/udev.{cc,h} into device/udev_linux/scoped_udev.h. - Update header files elsewhere. - Use ScopedUdev*Ptr classes in more places. BUG=415212 Committed: https://crrev.com/62675d9fb31fb8cedc40f68e78e8445a74f362e7 Cr-Commit-Position: refs/heads/master@{#300999}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -189 lines) Patch
A + chrome/browser/extensions/api/image_writer_private/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/image_writer_private/removable_storage_provider_linux.cc View 4 chunks +32 lines, -37 lines 0 comments Download
M components/storage_monitor/storage_monitor_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/storage_monitor/udev_util_linux.h View 2 chunks +3 lines, -3 lines 0 comments Download
M components/storage_monitor/udev_util_linux.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/DEPS View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/gamepad/gamepad_platform_data_fetcher_linux.cc View 6 chunks +21 lines, -25 lines 0 comments Download
M content/browser/udev_linux.h View 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/udev_linux.cc View 3 chunks +8 lines, -12 lines 0 comments Download
M device/hid/device_monitor_linux.h View 1 chunk +1 line, -1 line 0 comments Download
M device/hid/hid_service_linux.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M device/serial/serial_device_enumerator_linux.h View 2 chunks +2 lines, -8 lines 0 comments Download
M device/serial/serial_device_enumerator_linux.cc View 2 chunks +1 line, -17 lines 0 comments Download
M device/udev_linux/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
A + device/udev_linux/scoped_udev.h View 3 chunks +15 lines, -7 lines 0 comments Download
D device/udev_linux/udev.h View 1 chunk +0 lines, -38 lines 0 comments Download
D device/udev_linux/udev.cc View 1 chunk +0 lines, -27 lines 0 comments Download
M device/udev_linux/udev.gyp View 1 chunk +1 line, -2 lines 0 comments Download
M device/usb/usb_device_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/ozone/device/udev/device_manager_udev.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (3 generated)
Lei Zhang
I'm going to funnel all libudev access through device/udev_linux in an upcoming CL. I'd like ...
6 years, 2 months ago (2014-10-20 19:31:46 UTC) #2
Reilly Grant (use Gerrit)
lgtm
6 years, 2 months ago (2014-10-20 19:41:56 UTC) #3
Lei Zhang
+spang for ozone. +jam for contents
6 years, 2 months ago (2014-10-20 20:07:00 UTC) #5
spang
lgtm
6 years, 2 months ago (2014-10-20 20:53:59 UTC) #6
jam
On 2014/10/20 20:07:00, Lei Zhang wrote: > +spang for ozone. > +jam for contents I'm ...
6 years, 2 months ago (2014-10-22 22:43:11 UTC) #7
Lei Zhang
On 2014/10/22 22:43:11, jam wrote: > On 2014/10/20 20:07:00, Lei Zhang wrote: > > +spang ...
6 years, 2 months ago (2014-10-22 22:46:04 UTC) #8
Lei Zhang
On 2014/10/22 22:46:04, Lei Zhang wrote: > On 2014/10/22 22:43:11, jam wrote: > > On ...
6 years, 2 months ago (2014-10-23 00:11:35 UTC) #9
jam
On 2014/10/23 00:11:35, Lei Zhang wrote: > On 2014/10/22 22:46:04, Lei Zhang wrote: > > ...
6 years, 2 months ago (2014-10-23 20:53:46 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/666653002/40001
6 years, 2 months ago (2014-10-23 23:01:11 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 2 months ago (2014-10-24 00:21:25 UTC) #13
commit-bot: I haz the power
6 years, 2 months ago (2014-10-24 00:22:01 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/62675d9fb31fb8cedc40f68e78e8445a74f362e7
Cr-Commit-Position: refs/heads/master@{#300999}

Powered by Google App Engine
This is Rietveld 408576698