Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 666613002: ASSERT that characterIndexForXPosition has a GlyphToCharacter vector (Closed)

Created:
6 years, 2 months ago by eae
Modified:
6 years, 2 months ago
CC:
blink-reviews, krit, Rik, jbroman, mkwst+moarreviews_chromium.org, danakj, pdr+graphicswatchlist_chromium.org, Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

ASSERT that characterIndexForXPosition has a GlyphToCharacter vector ASSERT that the m_glyphToCharacterIndexes vector is available in the characterIndexForXPosition method. BUG=423649 R=jln@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183930

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M Source/platform/fonts/shaping/HarfBuzzShaper.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
eae
6 years, 2 months ago (2014-10-17 21:07:13 UTC) #1
eae
6 years, 2 months ago (2014-10-17 21:37:34 UTC) #3
jln (very slow on Chromium)
I know nothing about this area, did you mean someone else? lgtm, as this is ...
6 years, 2 months ago (2014-10-17 21:43:09 UTC) #5
eae
On 2014/10/17 21:43:09, jln wrote: > I know nothing about this area, did you mean ...
6 years, 2 months ago (2014-10-17 21:48:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/666613002/1
6 years, 2 months ago (2014-10-17 21:49:23 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 22:11:00 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183930

Powered by Google App Engine
This is Rietveld 408576698