Source/platform/fonts/shaping/HarfBuzzShaper.cpp - Issue 666613002: ASSERT that characterIndexForXPosition has a GlyphToCharacter vector

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/fonts/shaping/HarfBuzzShaper.cpp

Issue 666613002: ASSERT that characterIndexForXPosition has a GlyphToCharacter vector (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/platform/fonts/shaping/HarfBuzzShaper.cpp

diff --git a/Source/platform/fonts/shaping/HarfBuzzShaper.cpp b/Source/platform/fonts/shaping/HarfBuzzShaper.cpp

index 8f0042a357d1087438306c59247fc80b0b2cb437..0741f1ed05f7c80247359fdf9c1bba0f63ee24bb 100644

--- a/Source/platform/fonts/shaping/HarfBuzzShaper.cpp

+++ b/Source/platform/fonts/shaping/HarfBuzzShaper.cpp

@@ -317,6 +317,7 @@ int HarfBuzzShaper::HarfBuzzRun::characterIndexForXPosition(float targetX)

float HarfBuzzShaper::HarfBuzzRun::xPositionForOffset(unsigned offset)

{

ASSERT(offset < m_numCharacters);

+ ASSERT(hasGlyphToCharacterIndexes());

unsigned glyphIndex = 0;

float position = 0;

if (rtl()) {

« no previous file with comments | « no previous file | no next file » | no next file with comments »