Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: components/constrained_window/constrained_window_views.h

Issue 666533007: Move JavaScriptDialogManager, JavascriptAppModalDialogViews to components/app_modal_dialogs (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/constrained_window/constrained_window_views.h
diff --git a/components/constrained_window/constrained_window_views.h b/components/constrained_window/constrained_window_views.h
index c638f7e9d45d74838a7a379883262f277dbfe212..cad2642b559dacda7f4e9196c73d8be4ad4e2d02 100644
--- a/components/constrained_window/constrained_window_views.h
+++ b/components/constrained_window/constrained_window_views.h
@@ -48,9 +48,10 @@ views::Widget* ShowWebModalDialogViews(
views::Widget* CreateWebModalDialogViews(views::WidgetDelegate* dialog,
content::WebContents* web_contents);
-// Create a widget for |dialog| that is modal to the browser window |parent|.
-// This places the dialog appropriately if |parent| is a valid browser window.
-views::Widget* CreateBrowserModalDialogViews(views::DialogDelegate* dialog,
- gfx::NativeWindow parent);
+// Create a widget for |dialog| that is modal to the entire app that |parent|
+// window belongs to. This places the dialog appropriately if |parent| has
+// an associated ModalDialogHost.
+views::Widget* CreateAppModalDialogViews(views::DialogDelegate* dialog,
+ gfx::NativeWindow parent);
#endif // COMPONENTS_CONSTRAINED_WINDOW_CONSTRAINED_WINDOW_VIEWS_H_

Powered by Google App Engine
This is Rietveld 408576698