Move JavaScriptDialogManager, JavascriptAppModalDialogViews to components/app_modal_dialogs

components/constrained_window/constrained_window_views.cc

Index: components/constrained_window/constrained_window_views.cc
diff --git a/components/constrained_window/constrained_window_views.cc b/components/constrained_window/constrained_window_views.cc
index 68664fbe93579fbd3700a0f7270996df382602ef..189a18044a67e1d9ae566c4962b1988be1425723 100644
--- a/components/constrained_window/constrained_window_views.cc
+++ b/components/constrained_window/constrained_window_views.cc
@@ -152,8 +152,8 @@ views::Widget* CreateWebModalDialogViews(views::WidgetDelegate* dialog,
 }
 
 // TODO(gbillock): Replace this with PopupManager calls.
-views::Widget* CreateBrowserModalDialogViews(views::DialogDelegate* dialog,
-                                             gfx::NativeWindow parent) {
+views::Widget* CreateAppModalDialogViews(views::DialogDelegate* dialog,

[msw, 2014/11/05 03:53:56]

This tangential function renaming affects too many files to be part of such a
large, complex CL; this really should be landed first to simplify the review of
the actual componentization changes.

[oshima, 2014/11/05 21:42:19]

This was to keep the name consistent with c14n change + comment, and I didn't
expect this is controversial. I agree that this should be done separately now.
Removed these changes.

+                                            gfx::NativeWindow parent) {

[msw, 2014/11/05 03:53:56]

nit: fix indent.

[oshima, 2014/11/05 21:42:19]

Done.

   views::Widget* widget =
       views::DialogDelegate::CreateDialogWidget(dialog, NULL, parent);
   if (!dialog->UseNewStyleForThisDialog())