chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc - Issue 666533007: Move JavaScriptDialogManager, JavascriptAppModalDialogViews to components/app_modal_dialogs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc

Issue 666533007: Move JavaScriptDialogManager, JavascriptAppModalDialogViews to components/app_modal_dialogs (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/chrome_javascript_native_dialog_factory_cocoa.mm ('K') | « chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.mm ('k') | chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc » ('j') | chrome/browser/ui/views/chrome_javascript_native_dialog_factory.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc

diff --git a/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc b/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc

index 8a8197e997a8757be3e4122996228b887d769b2e..ce081844b3445037acaf80b152d9a5acd91016b5 100644

--- a/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc

+++ b/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc

@@ -44,7 +44,7 @@ void ShowAppInfoInAppList(gfx::NativeWindow parent,

views::View* app_info_view = new AppInfoDialog(parent, profile, app);

views::DialogDelegate* dialog =

CreateAppListContainerForView(app_info_view, close_callback);

- views::Widget* dialog_widget = CreateBrowserModalDialogViews(dialog, parent);

+ views::Widget* dialog_widget = CreateAppModalDialogViews(dialog, parent);

dialog_widget->SetBounds(app_list_bounds);

dialog_widget->Show();

}

@@ -57,7 +57,7 @@ void ShowAppInfoInNativeDialog(gfx::NativeWindow parent,

views::View* app_info_view = new AppInfoDialog(parent, profile, app);

views::DialogDelegate* dialog =

CreateDialogContainerForView(app_info_view, size, close_callback);

- views::Widget* dialog_widget = CreateBrowserModalDialogViews(dialog, parent);

+ views::Widget* dialog_widget = CreateAppModalDialogViews(dialog, parent);

dialog_widget->Show();

}