chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.mm - Issue 666533007: Move JavaScriptDialogManager, JavascriptAppModalDialogViews to components/app_modal_dialogs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.mm

Issue 666533007: Move JavaScriptDialogManager, JavascriptAppModalDialogViews to components/app_modal_dialogs (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/chrome_javascript_native_dialog_factory_cocoa.mm ('K') | « chrome/browser/ui/cocoa/chrome_javascript_native_dialog_factory_cocoa.mm ('k') | chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc » ('j') | chrome/browser/ui/views/chrome_javascript_native_dialog_factory.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.mm b/chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.mm

index 37c4ad7a132ca5d0b88ebad58f7fe2a403d9e321..29d7c3377ba5fd61458e0ec7c0ae2e97f76b7af9 100644

--- a/chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.mm

+++ b/chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.mm

@@ -11,7 +11,6 @@

#import "base/mac/foundation_util.h"

#include "base/strings/sys_string_conversions.h"

#import "chrome/browser/chrome_browser_application_mac.h"

-#include "chrome/grit/generated_resources.h"

#include "components/app_modal_dialogs/javascript_app_modal_dialog.h"

#include "grit/components_strings.h"

#include "ui/base/l10n/l10n_util_mac.h"

@@ -434,13 +433,3 @@ void JavaScriptAppModalDialogCocoa::AcceptAppModalDialog() {

void JavaScriptAppModalDialogCocoa::CancelAppModalDialog() {

[helper_ playOrQueueAction:ACTION_CANCEL];

}

-////////////////////////////////////////////////////////////////////////////////

-// NativeAppModalDialog, public:

-// static

-NativeAppModalDialog* NativeAppModalDialog::CreateNativeJavaScriptPrompt(

- JavaScriptAppModalDialog* dialog,

- gfx::NativeWindow parent_window) {

- return new JavaScriptAppModalDialogCocoa(dialog);