extensions/components/javascript_dialog_extensions_client/BUILD.gn - Issue 666533007: Move JavaScriptDialogManager, JavascriptAppModalDialogViews to components/app_modal_dialogs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/components/javascript_dialog_extensions_client/BUILD.gn

Issue 666533007: Move JavaScriptDialogManager, JavascriptAppModalDialogViews to components/app_modal_dialogs (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: similarity=30 Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/constrained_window/constrained_window_views.h ('K') | « extensions/components/javascript_dialog_extensions_client.gypi ('k') | extensions/components/javascript_dialog_extensions_client/DEPS » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/components/javascript_dialog_extensions_client/BUILD.gn

diff --git a/extensions/components/native_app_window/BUILD.gn b/extensions/components/javascript_dialog_extensions_client/BUILD.gn

similarity index 56%

copy from extensions/components/native_app_window/BUILD.gn

copy to extensions/components/javascript_dialog_extensions_client/BUILD.gn

index 28330bc6544f2d8b659e5291bf5235f6e20ded8c..46acd3a6668cffb44acbdef7174df17f068d4165 100644

--- a/extensions/components/native_app_window/BUILD.gn

+++ b/extensions/components/javascript_dialog_extensions_client/BUILD.gn

@@ -2,18 +2,15 @@

# Use of this source code is governed by a BSD-style license that can be

# found in the LICENSE file.

-static_library("native_app_window") {

+static_library("javascript_dialog_extensions_client") {

sources = [

- "native_app_window_views.cc",

- "native_app_window_views.h",

+ "javascript_dialog_extension_client_impl.cc",

+ "javascript_dialog_extension_client_impl.h",

]

deps = [

- "//base",

"//skia",

- "//ui/views",

- "//ui/views/controls/webview",

- "//content/public/browser",

+ "//components/app_modal_dialogs",

"//extensions/browser",

"//extensions/common",

Avi (use Gerrit) 2014/11/04 20:46:41 Is this supposed to be alphabetized? (Honest quest

oshima 2014/11/04 23:12:18 Yes, I think so. Done.

]