extensions/components/javascript_dialog_extensions_client.gypi - Issue 666533007: Move JavaScriptDialogManager, JavascriptAppModalDialogViews to components/app_modal_dialogs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/components/javascript_dialog_extensions_client.gypi

Issue 666533007: Move JavaScriptDialogManager, JavascriptAppModalDialogViews to components/app_modal_dialogs (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: similarity=30 Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/constrained_window/constrained_window_views.h ('K') | « extensions/components/extensions_components.gyp ('k') | extensions/components/javascript_dialog_extensions_client/BUILD.gn » ('j') | extensions/components/javascript_dialog_extensions_client/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/components/javascript_dialog_extensions_client.gypi

diff --git a/extensions/components/native_app_window.gypi b/extensions/components/javascript_dialog_extensions_client.gypi

similarity index 57%

copy from extensions/components/native_app_window.gypi

copy to extensions/components/javascript_dialog_extensions_client.gypi

index 5af1c9265493cf5fdcb2c7dd1e7f0821757468a5..40d10298341513e233801186dbd3240750ace6e8 100644

--- a/extensions/components/native_app_window.gypi

+++ b/extensions/components/javascript_dialog_extensions_client.gypi

@@ -4,14 +4,11 @@

{

'targets': [

{

- 'target_name': 'native_app_window',

+ 'target_name': 'javascript_dialog_extensions_client',

'type': 'static_library',

'dependencies': [

- '../../base/base.gyp:base',

- '../../content/content.gyp:content_browser',

+ '../../components/components.gyp:app_modal_dialogs',

'../../skia/skia.gyp:skia',

- '../../ui/views/views.gyp:views',

- '../../ui/views/controls/webview/webview.gyp:webview',

'../extensions.gyp:extensions_browser',

'../extensions.gyp:extensions_common',

@@ -19,8 +16,8 @@

'../..',

'sources': [

- 'native_app_window/native_app_window_views.cc',

- 'native_app_window/native_app_window_views.h',

+ 'javascript_dialog_extensions_client/javascript_dialog_extension_client_impl.cc',

+ 'javascript_dialog_extensions_client/javascript_dialog_extension_client_impl.h',