components/constrained_window/constrained_window_views.cc - Issue 666533007: Move JavaScriptDialogManager, JavascriptAppModalDialogViews to components/app_modal_dialogs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/constrained_window/constrained_window_views.cc

Issue 666533007: Move JavaScriptDialogManager, JavascriptAppModalDialogViews to components/app_modal_dialogs (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: similarity=30 Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/constrained_window/constrained_window_views.h ('K') | « components/constrained_window/constrained_window_views.h ('k') | extensions/components/extensions_components.gyp » ('j') | extensions/components/javascript_dialog_extensions_client/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/constrained_window/constrained_window_views.cc

diff --git a/components/constrained_window/constrained_window_views.cc b/components/constrained_window/constrained_window_views.cc

index 68664fbe93579fbd3700a0f7270996df382602ef..cef95eb56fde0d530e9e92eb30abcc8468d304cb 100644

--- a/components/constrained_window/constrained_window_views.cc

+++ b/components/constrained_window/constrained_window_views.cc

@@ -152,8 +152,8 @@ views::Widget* CreateWebModalDialogViews(views::WidgetDelegate* dialog,

}

// TODO(gbillock): Replace this with PopupManager calls.

-views::Widget* CreateBrowserModalDialogViews(views::DialogDelegate* dialog,

- gfx::NativeWindow parent) {

+views::Widget* CreateWindowModalDialogViews(views::DialogDelegate* dialog,

+ gfx::NativeWindow parent) {

views::Widget* widget =

views::DialogDelegate::CreateDialogWidget(dialog, NULL, parent);

if (!dialog->UseNewStyleForThisDialog())