Move JavaScriptDialogManager, JavascriptAppModalDialogViews to components/app_modal_dialogs

chrome/browser/ui/app_modal_dialogs/chrome_javascript_dialog_manager_client.h

Index: chrome/browser/ui/app_modal_dialogs/chrome_javascript_dialog_manager_client.h
diff --git a/chrome/browser/ui/app_modal_dialogs/chrome_javascript_dialog_manager_client.h b/chrome/browser/ui/app_modal_dialogs/chrome_javascript_dialog_manager_client.h
new file mode 100644
index 0000000000000000000000000000000000000000..3f1982c16fe2b297c32d38aa40ed238e154f8839
--- /dev/null
+++ b/chrome/browser/ui/app_modal_dialogs/chrome_javascript_dialog_manager_client.h
@@ -0,0 +1,45 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_APP_MODAL_DIALOGS_CHROME_JAVASCRIPT_DIALOG_MANAGER_CLIENT_H_
+#define CHROME_BROWSER_UI_APP_MODAL_DIALOGS_CHROME_JAVASCRIPT_DIALOG_MANAGER_CLIENT_H_
+
+#include "base/memory/scoped_ptr.h"
+#include "components/app_modal_dialogs/javascript_dialog_manager_client.h"
+#include "ui/gfx/native_widget_types.h"
+
+class JavaScriptAppModalDialog;
+class NativeAppModalDialog;
+
+class ChromeJavaScriptDialogManagerClient
+    : public JavaScriptDialogManagerClient {
+ public:
+  ChromeJavaScriptDialogManagerClient();
+  ~ChromeJavaScriptDialogManagerClient() override;
+
+  // JavaScriptDialogManagerClient:
+  NativeAppModalDialog* CreateNativeJavaScriptPrompt(
+      JavaScriptAppModalDialog* dialog,
+      gfx::NativeWindow parent_window) override;
+  void IncrementLazyKeepaliveCount(
+      content::WebContents* web_contents) override;
+  void DecrementLazyKeepaliveCount(
+      content::WebContents* web_contents) override;
+  bool GetExtensionName(content::WebContents* web_contents,
+                        const GURL& origin_url,
+                        std::string* name_out) override;
+
+  // Creates a platform specific impl of NativeAppModalDialog for
+  // Chrome's javascript prompt.  This is implemented by platform
+  // specific files.

[Avi (use Gerrit), 2014/10/29 17:40:57]

Are we eventually going to move everything over to the component?

[oshima, 2014/10/31 15:54:45]

I looked into it, but this turns out to be more complex than I originally
thought, android code depends on JNI and java code, and linux desktop one
requires refactoring x11 specific code (see peter's comment).

Since there is no real benefit to move other impl to components, I want to leave
them as is unless there is a demand.

+  static NativeAppModalDialog* CreateChromeNativeJavaScriptPrompt(
+      JavaScriptAppModalDialog* dialog,
+      gfx::NativeWindow parent_window);
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(ChromeJavaScriptDialogManagerClient);
+};
+
+#endif  // CHROME_BROWSER_UI_APP_MODAL_DIALOGS_CHROME_JAVASCRIPT_DIALOG_MANAGER_CLIENT_H_
+