Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: components/app_modal_dialogs.gypi

Issue 666533007: Move JavaScriptDialogManager, JavascriptAppModalDialogViews to components/app_modal_dialogs (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/app_modal_dialogs.gypi
diff --git a/components/app_modal_dialogs.gypi b/components/app_modal_dialogs.gypi
index df3c3ec73fdc8e0ffb0e9807315438cd8f82f56e..26cc47031206c257571f01841f3daf8731e316de 100644
--- a/components/app_modal_dialogs.gypi
+++ b/components/app_modal_dialogs.gypi
@@ -7,8 +7,9 @@
'target_name': 'app_modal_dialogs',
'type': 'static_library',
'dependencies': [
- '../skia/skia.gyp:skia',
+ '../skia/skia.gyp:skia',
'../content/content.gyp:content_browser',
+ '../content/content.gyp:content_common',
Avi (use Gerrit) 2014/10/29 17:40:57 alphabetize?
oshima 2014/10/31 15:54:45 Done.
'components_strings.gyp:components_strings',
],
'include_dirs': [
@@ -22,6 +23,10 @@
'app_modal_dialogs/app_modal_dialog_queue.h',
'app_modal_dialogs/javascript_app_modal_dialog.cc',
'app_modal_dialogs/javascript_app_modal_dialog.h',
+ 'app_modal_dialogs/javascript_dialog_manager.cc',
+ 'app_modal_dialogs/javascript_dialog_manager.h',
+ 'app_modal_dialogs/javascript_dialog_manager_client.cc',
+ 'app_modal_dialogs/javascript_dialog_manager_client.h',
'app_modal_dialogs/native_app_modal_dialog.h'
],
'conditions': [
@@ -29,7 +34,13 @@
'dependencies': [
'../ui/aura/aura.gyp:aura',
],
- }]
+ }],
+ ['toolkit_views==1 and OS != "mac"', {
+ 'sources': [
+ 'app_modal_dialogs/views/javascript_app_modal_dialog_views.h',
+ 'app_modal_dialogs/views/javascript_app_modal_dialog_views.cc',
+ ],
+ }],
],
},
],

Powered by Google App Engine
This is Rietveld 408576698