Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Issue 666493005: Standardize usage of virtual/override/final in ipc/ (Closed)

Created:
6 years, 2 months ago by dcheng
Modified:
6 years, 2 months ago
Reviewers:
agl
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, jam, mkwst+moarreviews-ipc_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Standardize usage of virtual/override/final in ipc/ The Google C++ style guide states: Explicitly annotate overrides of virtual functions or virtual destructors with an override or (less frequently) final specifier. Older (pre-C++11) code will use the virtual keyword as an inferior alternative annotation. For clarity, use exactly one of override, final, or virtual when declaring an override. To better conform to these guidelines, the following constructs have been rewritten: - if a base class has a virtual destructor, then: virtual ~Foo(); -> ~Foo() override; - virtual void Foo() override; -> void Foo() override; - virtual void Foo() override final; -> void Foo() final; This patch was automatically generated. The clang plugin can generate fixit hints, which are suggested edits when it is 100% sure it knows how to fix a problem. The hints from the clang plugin were applied to the source tree using the tool in https://codereview.chromium.org/598073004. Several formatting edits by clang-format were manually reverted, due to mangling of some of the more complicate IPC macros. BUG=417463 R=agl@chromium.org Committed: https://crrev.com/fe61fca6faca13c54768ee131dc79c8e06421097 Cr-Commit-Position: refs/heads/master@{#300623}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+197 lines, -208 lines) Patch
M ipc/ipc_channel.h View 1 chunk +1 line, -2 lines 0 comments Download
M ipc/ipc_channel_factory.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M ipc/ipc_channel_posix.h View 3 chunks +14 lines, -16 lines 0 comments Download
M ipc/ipc_channel_posix_unittest.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M ipc/ipc_channel_proxy.h View 3 chunks +6 lines, -6 lines 0 comments Download
M ipc/ipc_channel_proxy_unittest.cc View 8 chunks +13 lines, -13 lines 0 comments Download
M ipc/ipc_channel_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ipc/ipc_forwarding_message_filter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ipc/ipc_fuzzing_tests.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ipc/ipc_message.h View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_message_macros.h View 4 chunks +4 lines, -4 lines 0 comments Download
M ipc/ipc_perftest_support.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M ipc/ipc_send_fds_test.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M ipc/ipc_sync_channel.h View 2 chunks +8 lines, -8 lines 0 comments Download
M ipc/ipc_sync_channel_unittest.cc View 45 chunks +50 lines, -50 lines 0 comments Download
M ipc/ipc_sync_message.h View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_sync_message_filter.h View 1 chunk +6 lines, -6 lines 0 comments Download
M ipc/ipc_test_channel_listener.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ipc/ipc_test_sink.h View 1 chunk +8 lines, -8 lines 0 comments Download
M ipc/mojo/ipc_channel_mojo.h View 2 chunks +10 lines, -11 lines 0 comments Download
M ipc/mojo/ipc_channel_mojo.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ipc/mojo/ipc_channel_mojo_host.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M ipc/mojo/ipc_channel_mojo_readers.h View 4 chunks +9 lines, -9 lines 0 comments Download
M ipc/mojo/ipc_channel_mojo_unittest.cc View 11 chunks +16 lines, -18 lines 0 comments Download
M ipc/mojo/ipc_mojo_bootstrap.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ipc/mojo/ipc_mojo_bootstrap.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M ipc/mojo/ipc_mojo_bootstrap_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M ipc/mojo/ipc_mojo_perftest.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M ipc/sync_socket_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ipc/unix_domain_socket_util_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
dcheng
I think I've reverted all the clang-format changes that you objected in https://codereview.chromium.org/645623006/
6 years, 2 months ago (2014-10-21 18:55:37 UTC) #1
agl
lgtm
6 years, 2 months ago (2014-10-22 00:34:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/666493005/1
6 years, 2 months ago (2014-10-22 00:36:23 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/66253)
6 years, 2 months ago (2014-10-22 01:25:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/666493005/1
6 years, 2 months ago (2014-10-22 01:35:31 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-22 02:30:19 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 04:05:33 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fe61fca6faca13c54768ee131dc79c8e06421097
Cr-Commit-Position: refs/heads/master@{#300623}

Powered by Google App Engine
This is Rietveld 408576698