ipc/ipc_message_macros.h - Issue 666493005: Standardize usage of virtual/override/final in ipc/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ipc/ipc_message_macros.h

Issue 666493005: Standardize usage of virtual/override/final in ipc/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ipc/ipc_message_macros.h

diff --git a/ipc/ipc_message_macros.h b/ipc/ipc_message_macros.h

index 0978765b993df900978baf03eda2c843b59abfe0..96cc20ba85ff1abefa378738cc0e83678b188385 100644

--- a/ipc/ipc_message_macros.h

+++ b/ipc/ipc_message_macros.h

@@ -600,7 +600,7 @@

typedef Schema::Param Param; \

enum { ID = IPC_MESSAGE_ID() }; \

msg_class(IPC_TYPE_IN_##in_cnt in_list); \

- virtual ~msg_class(); \

+ ~msg_class() override; \

static bool Read(const Message* msg, Schema::Param* p); \

static void Log(std::string* name, const Message* msg, std::string* l); \

IPC_ASYNC_MESSAGE_METHODS_##in_cnt \

@@ -614,7 +614,7 @@

enum { ID = IPC_MESSAGE_ID() }; \

msg_class(int32 routing_id IPC_COMMA_##in_cnt \

IPC_TYPE_IN_##in_cnt in_list); \

- virtual ~msg_class(); \

+ ~msg_class() override; \

static bool Read(const Message* msg, Schema::Param* p); \

static void Log(std::string* name, const Message* msg, std::string* l); \

IPC_ASYNC_MESSAGE_METHODS_##in_cnt \

@@ -631,7 +631,7 @@

msg_class(IPC_TYPE_IN_##in_cnt in_list \

IPC_COMMA_AND_##in_cnt(IPC_COMMA_##out_cnt) \

IPC_TYPE_OUT_##out_cnt out_list); \

- virtual ~msg_class(); \

+ ~msg_class() override; \

static bool ReadSendParam(const Message* msg, Schema::SendParam* p); \

static bool ReadReplyParam( \

const Message* msg, \

@@ -653,7 +653,7 @@

IPC_TYPE_IN_##in_cnt in_list \

IPC_COMMA_AND_##in_cnt(IPC_COMMA_##out_cnt) \

IPC_TYPE_OUT_##out_cnt out_list); \

- virtual ~msg_class(); \

+ ~msg_class() override; \

static bool ReadSendParam(const Message* msg, Schema::SendParam* p); \

static bool ReadReplyParam( \

const Message* msg, \

« no previous file with comments | « ipc/ipc_message.h ('k') | ipc/ipc_perftest_support.cc » ('j') | no next file with comments »