Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: tools/clang/blink_gc_plugin/tests/fields_require_tracing.txt

Issue 666473003: Blink GC plugin: Gracefully handle cyclic part objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/clang/blink_gc_plugin/tests/fields_require_tracing.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/blink_gc_plugin/tests/fields_require_tracing.txt
diff --git a/tools/clang/blink_gc_plugin/tests/fields_require_tracing.txt b/tools/clang/blink_gc_plugin/tests/fields_require_tracing.txt
index cafa32ff1eee723dbce83dd596c26735f60df81f..39d49f340eda5f3816fd9c28a0790584fa511bd5 100644
--- a/tools/clang/blink_gc_plugin/tests/fields_require_tracing.txt
+++ b/tools/clang/blink_gc_plugin/tests/fields_require_tracing.txt
@@ -1,16 +1,22 @@
fields_require_tracing.cpp:9:1: warning: [blink-gc] Class 'PartObject' has untraced fields that require tracing.
void PartObject::trace(Visitor* visitor) {
^
-./fields_require_tracing.h:19:5: note: [blink-gc] Untraced field 'm_obj1' declared here:
+./fields_require_tracing.h:29:5: note: [blink-gc] Untraced field 'm_obj1' declared here:
Member<HeapObject> m_obj1;
^
-./fields_require_tracing.h:21:5: note: [blink-gc] Untraced field 'm_obj3' declared here:
+./fields_require_tracing.h:31:5: note: [blink-gc] Untraced field 'm_obj3' declared here:
Member<HeapObject> m_obj3;
^
-fields_require_tracing.cpp:15:1: warning: [blink-gc] Class 'HeapObject' has untraced fields that require tracing.
+fields_require_tracing.cpp:16:1: warning: [blink-gc] Class 'PartBObject' has untraced fields that require tracing.
+void PartBObject::trace(Visitor* visitor) {
+^
+./fields_require_tracing.h:20:5: note: [blink-gc] Untraced field 'm_set' declared here:
+ HeapHashSet<PartBObject> m_set;
+ ^
+fields_require_tracing.cpp:21:1: warning: [blink-gc] Class 'HeapObject' has untraced fields that require tracing.
void HeapObject::trace(Visitor* visitor) {
^
-./fields_require_tracing.h:28:5: note: [blink-gc] Untraced field 'm_part' declared here:
+./fields_require_tracing.h:40:5: note: [blink-gc] Untraced field 'm_part' declared here:
PartObject m_part;
^
-2 warnings generated.
+3 warnings generated.
« no previous file with comments | « tools/clang/blink_gc_plugin/tests/fields_require_tracing.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698