Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: tools/clang/blink_gc_plugin/tests/fields_require_tracing.txt

Issue 666473003: Blink GC plugin: Gracefully handle cyclic part objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/clang/blink_gc_plugin/tests/fields_require_tracing.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 fields_require_tracing.cpp:9:1: warning: [blink-gc] Class 'PartObject' has untra ced fields that require tracing. 1 fields_require_tracing.cpp:9:1: warning: [blink-gc] Class 'PartObject' has untra ced fields that require tracing.
2 void PartObject::trace(Visitor* visitor) { 2 void PartObject::trace(Visitor* visitor) {
3 ^ 3 ^
4 ./fields_require_tracing.h:19:5: note: [blink-gc] Untraced field 'm_obj1' declar ed here: 4 ./fields_require_tracing.h:29:5: note: [blink-gc] Untraced field 'm_obj1' declar ed here:
5 Member<HeapObject> m_obj1; 5 Member<HeapObject> m_obj1;
6 ^ 6 ^
7 ./fields_require_tracing.h:21:5: note: [blink-gc] Untraced field 'm_obj3' declar ed here: 7 ./fields_require_tracing.h:31:5: note: [blink-gc] Untraced field 'm_obj3' declar ed here:
8 Member<HeapObject> m_obj3; 8 Member<HeapObject> m_obj3;
9 ^ 9 ^
10 fields_require_tracing.cpp:15:1: warning: [blink-gc] Class 'HeapObject' has untr aced fields that require tracing. 10 fields_require_tracing.cpp:16:1: warning: [blink-gc] Class 'PartBObject' has unt raced fields that require tracing.
11 void PartBObject::trace(Visitor* visitor) {
12 ^
13 ./fields_require_tracing.h:20:5: note: [blink-gc] Untraced field 'm_set' declare d here:
14 HeapHashSet<PartBObject> m_set;
15 ^
16 fields_require_tracing.cpp:21:1: warning: [blink-gc] Class 'HeapObject' has untr aced fields that require tracing.
11 void HeapObject::trace(Visitor* visitor) { 17 void HeapObject::trace(Visitor* visitor) {
12 ^ 18 ^
13 ./fields_require_tracing.h:28:5: note: [blink-gc] Untraced field 'm_part' declar ed here: 19 ./fields_require_tracing.h:40:5: note: [blink-gc] Untraced field 'm_part' declar ed here:
14 PartObject m_part; 20 PartObject m_part;
15 ^ 21 ^
16 2 warnings generated. 22 3 warnings generated.
OLDNEW
« no previous file with comments | « tools/clang/blink_gc_plugin/tests/fields_require_tracing.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698