Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 666443002: Additional logging for crash mentioned in crbug.com/422918 (Closed)

Created:
6 years, 2 months ago by Denis Kuznetsov (DE-MUC)
Modified:
6 years, 1 month ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, pam+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git/+/master
Project:
chromium
Visibility:
Public.

Description

Additional logging for crash mentioned in crbug.com/422918 R=nkostylev@chromium.org Committed: https://crrev.com/ccf0a3a12db123cb297f59b0e2c10af269049a3c Cr-Commit-Position: refs/heads/master@{#301407}

Patch Set 1 #

Patch Set 2 : Merge #

Patch Set 3 : Fix merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -8 lines) Patch
M chrome/browser/chromeos/login/auth/chrome_login_performer.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller.cc View 1 2 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/supervised/supervised_user_creation_flow.cc View 1 2 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/user_flow.h View 1 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/chromeos/login/user_flow.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Denis Kuznetsov (DE-MUC)
6 years, 2 months ago (2014-10-17 12:51:59 UTC) #1
Nikita (slow)
lgtm please reference that bug in this CL. I don't think that realistically we'll be ...
6 years, 2 months ago (2014-10-17 13:12:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/666443002/40001
6 years, 1 month ago (2014-10-27 18:27:40 UTC) #4
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-10-27 19:30:45 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 19:31:28 UTC) #6
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ccf0a3a12db123cb297f59b0e2c10af269049a3c
Cr-Commit-Position: refs/heads/master@{#301407}

Powered by Google App Engine
This is Rietveld 408576698