chrome/browser/chromeos/login/existing_user_controller.cc - Issue 666443002: Additional logging for crash mentioned in crbug.com/422918

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/existing_user_controller.cc

Issue 666443002: Additional logging for crash mentioned in crbug.com/422918 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git/+/master

Patch Set: Fix merge Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/auth/chrome_login_performer.cc ('k') | chrome/browser/chromeos/login/supervised/supervised_user_creation_flow.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/existing_user_controller.cc

diff --git a/chrome/browser/chromeos/login/existing_user_controller.cc b/chrome/browser/chromeos/login/existing_user_controller.cc

index 54cf518e3bfbf3618853f5c4ca5a00b602669e1f..d1cc7a80fd4bfbe391cc8e0b0cb6bea2ee5afd41 100644

--- a/chrome/browser/chromeos/login/existing_user_controller.cc

+++ b/chrome/browser/chromeos/login/existing_user_controller.cc

@@ -446,8 +446,11 @@ void ExistingUserController::Login(const UserContext& user_context,

void ExistingUserController::PerformLogin(

const UserContext& user_context,

LoginPerformer::AuthorizationMode auth_mode) {

- ChromeUserManager::Get()->GetUserFlow(user_context.GetUserID())->set_host(

- host_);

+ // TODO(antrim): remove this output once crash reason is found.

+ LOG(ERROR) << "Setting flow from PerformLogin";

+ ChromeUserManager::Get()

+ ->GetUserFlow(user_context.GetUserID())

+ ->SetHost(host_);

BootTimesLoader::Get()->RecordLoginAttempted();