Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 666223003: Simplify TurboFan's c1visualizer file handling. (Closed)

Created:
6 years, 2 months ago by Sven Panne
Modified:
6 years, 2 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Simplify TurboFan's c1visualizer file handling. Still having GetTurboCfgFileName in Isolate is ugly, but if we decide that we don't want to truncate the output file (which would be consistent with --trace-hydrogen), this could be moved to TurboCfgFile where it actually belongs. R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24819

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -57 lines) Patch
M src/compiler/pipeline.h View 2 chunks +0 lines, -8 lines 0 comments Download
M src/compiler/pipeline.cc View 6 chunks +9 lines, -35 lines 0 comments Download
M src/isolate.h View 1 chunk +1 line, -1 line 0 comments Download
M src/isolate.cc View 2 chunks +7 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Sven Panne
6 years, 2 months ago (2014-10-22 09:52:52 UTC) #2
Benedikt Meurer
lgtm
6 years, 2 months ago (2014-10-23 07:22:19 UTC) #3
Sven Panne
6 years, 2 months ago (2014-10-23 07:26:23 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24819 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698