Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(731)

Unified Diff: src/isolate.cc

Issue 666223003: Simplify TurboFan's c1visualizer file handling. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/isolate.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/isolate.cc
diff --git a/src/isolate.cc b/src/isolate.cc
index 51c640902e891c06ad2821c2116eda257e598567..163bc645c67bfd0c7e69cc836c1efc2ed66d2f48 100644
--- a/src/isolate.cc
+++ b/src/isolate.cc
@@ -1955,12 +1955,8 @@ bool Isolate::Init(Deserializer* des) {
if (!create_heap_objects) Assembler::QuietNaN(heap_.nan_value());
if (FLAG_trace_turbo) {
- // Erase the file.
- char buffer[512];
- Vector<char> filename(buffer, sizeof(buffer));
- GetTurboCfgFileName(filename);
- std::ofstream turbo_cfg_stream(filename.start(),
- std::fstream::out | std::fstream::trunc);
+ // Create an empty file.
+ std::ofstream(GetTurboCfgFileName(), std::ios_base::trunc);
}
// If we are deserializing, log non-function code objects and compiled
@@ -2376,13 +2372,11 @@ BasicBlockProfiler* Isolate::GetOrCreateBasicBlockProfiler() {
}
-void Isolate::GetTurboCfgFileName(Vector<char> filename) {
- if (FLAG_trace_turbo_cfg_file == NULL) {
- SNPrintF(filename, "turbo-%d-%d.cfg", base::OS::GetCurrentProcessId(),
- id());
- } else {
- StrNCpy(filename, FLAG_trace_turbo_cfg_file, filename.length());
- }
+std::string Isolate::GetTurboCfgFileName() {
+ return FLAG_trace_turbo_cfg_file == NULL
+ ? "turbo-" + std::to_string(base::OS::GetCurrentProcessId()) +
+ "-" + std::to_string(id()) + ".cfg"
+ : FLAG_trace_turbo_cfg_file;
}
« no previous file with comments | « src/isolate.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698