Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3029)

Unified Diff: chrome/browser/extensions/extension_browsertest.cc

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_browsertest.cc
diff --git a/chrome/browser/extensions/extension_browsertest.cc b/chrome/browser/extensions/extension_browsertest.cc
index c91da49af78e8ceff2001d1efbccb58c24b2e13c..4113e2b87c60726a65951d1c931c3ec413ed1d4c 100644
--- a/chrome/browser/extensions/extension_browsertest.cc
+++ b/chrome/browser/extensions/extension_browsertest.cc
@@ -348,19 +348,16 @@ class MockAbortExtensionInstallPrompt : public ExtensionInstallPrompt {
}
// Simulate a user abort on an extension installation.
- virtual void ConfirmInstall(
- Delegate* delegate,
- const Extension* extension,
- const ShowDialogCallback& show_dialog_callback) override {
+ void ConfirmInstall(Delegate* delegate,
+ const Extension* extension,
+ const ShowDialogCallback& show_dialog_callback) override {
delegate->InstallUIAbort(true);
base::MessageLoopForUI::current()->Quit();
}
- virtual void OnInstallSuccess(const Extension* extension,
- SkBitmap* icon) override {}
+ void OnInstallSuccess(const Extension* extension, SkBitmap* icon) override {}
- virtual void OnInstallFailure(
- const extensions::CrxInstallerError& error) override {}
+ void OnInstallFailure(const extensions::CrxInstallerError& error) override {}
};
class MockAutoConfirmExtensionInstallPrompt : public ExtensionInstallPrompt {
@@ -370,10 +367,9 @@ class MockAutoConfirmExtensionInstallPrompt : public ExtensionInstallPrompt {
: ExtensionInstallPrompt(web_contents) {}
// Proceed without confirmation prompt.
- virtual void ConfirmInstall(
- Delegate* delegate,
- const Extension* extension,
- const ShowDialogCallback& show_dialog_callback) override {
+ void ConfirmInstall(Delegate* delegate,
+ const Extension* extension,
+ const ShowDialogCallback& show_dialog_callback) override {
delegate->InstallUIProceed();
}
};
« no previous file with comments | « chrome/browser/extensions/extension_browsertest.h ('k') | chrome/browser/extensions/extension_commands_global_registry.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698