chrome/browser/extensions/extension_commands_global_registry.h - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_commands_global_registry.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_browsertest.cc ('k') | chrome/browser/extensions/extension_context_menu_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_commands_global_registry.h

diff --git a/chrome/browser/extensions/extension_commands_global_registry.h b/chrome/browser/extensions/extension_commands_global_registry.h

index ccf0061a5dd4e0ecacd9e792c7655d82eb4ab47f..77daa1c8b0718b5dcaddc02dcb5f77d94aa38c4f 100644

--- a/chrome/browser/extensions/extension_commands_global_registry.h

+++ b/chrome/browser/extensions/extension_commands_global_registry.h

@@ -45,7 +45,7 @@ class ExtensionCommandsGlobalRegistry

static void SetShortcutHandlingSuspended(bool suspended);

explicit ExtensionCommandsGlobalRegistry(content::BrowserContext* context);

- virtual ~ExtensionCommandsGlobalRegistry();

+ ~ExtensionCommandsGlobalRegistry() override;

// Returns which non-global command registry is active (belonging to the

// currently active window).

@@ -70,16 +70,14 @@ class ExtensionCommandsGlobalRegistry

}

// Overridden from ExtensionKeybindingRegistry:

- virtual void AddExtensionKeybinding(

- const Extension* extension,

- const std::string& command_name) override;

- virtual void RemoveExtensionKeybindingImpl(

- const ui::Accelerator& accelerator,

- const std::string& command_name) override;

+ void AddExtensionKeybinding(const Extension* extension,

+ const std::string& command_name) override;

+ void RemoveExtensionKeybindingImpl(const ui::Accelerator& accelerator,

+ const std::string& command_name) override;

// Called by the GlobalShortcutListener object when a shortcut this class has

// registered for has been pressed.

- virtual void OnKeyPressed(const ui::Accelerator& accelerator) override;

+ void OnKeyPressed(const ui::Accelerator& accelerator) override;

// Weak pointer to our browser context. Not owned by us.

content::BrowserContext* browser_context_;