chrome/browser/extensions/api/preference/chrome_direct_setting_api.h - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/preference/chrome_direct_setting_api.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/preference/chrome_direct_setting.h ('k') | chrome/browser/extensions/api/preference/preference_api.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/preference/chrome_direct_setting_api.h

diff --git a/chrome/browser/extensions/api/preference/chrome_direct_setting_api.h b/chrome/browser/extensions/api/preference/chrome_direct_setting_api.h

index d10c03b0b9a121ae2b7c9690c40875581aace150..5fe14863e8bf4173c5309a2a926c2a414406183c 100644

--- a/chrome/browser/extensions/api/preference/chrome_direct_setting_api.h

+++ b/chrome/browser/extensions/api/preference/chrome_direct_setting_api.h

@@ -23,17 +23,17 @@ class ChromeDirectSettingAPI : public BrowserContextKeyedAPI,

public:

explicit ChromeDirectSettingAPI(content::BrowserContext* context);

- virtual ~ChromeDirectSettingAPI();

+ ~ChromeDirectSettingAPI() override;

// KeyedService implementation.

- virtual void Shutdown() override;

+ void Shutdown() override;

// BrowserContextKeyedAPI implementation.

static BrowserContextKeyedAPIFactory<ChromeDirectSettingAPI>*

GetFactoryInstance();

// EventRouter::Observer implementation.

- virtual void OnListenerAdded(const EventListenerInfo& details) override;

+ void OnListenerAdded(const EventListenerInfo& details) override;

// Returns true if the preference is on the whitelist.

bool IsPreferenceOnWhitelist(const std::string& pref_key);