Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3333)

Unified Diff: chrome/browser/extensions/api/preference/chrome_direct_setting.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/preference/chrome_direct_setting.h
diff --git a/chrome/browser/extensions/api/preference/chrome_direct_setting.h b/chrome/browser/extensions/api/preference/chrome_direct_setting.h
index aacbe1d8b787bc82e64072298ad33f7924539be1..f1ae69131453441c31317bab8f8a5e0657d828d1 100644
--- a/chrome/browser/extensions/api/preference/chrome_direct_setting.h
+++ b/chrome/browser/extensions/api/preference/chrome_direct_setting.h
@@ -17,7 +17,7 @@ namespace chromedirectsetting {
class DirectSettingFunctionBase : public ChromeSyncExtensionFunction {
protected:
DirectSettingFunctionBase();
- virtual ~DirectSettingFunctionBase();
+ ~DirectSettingFunctionBase() override;
// Returns the user pref service.
PrefService* GetPrefService();
@@ -38,10 +38,10 @@ class GetDirectSettingFunction : public DirectSettingFunctionBase {
protected:
// ExtensionFunction:
- virtual bool RunSync() override;
+ bool RunSync() override;
private:
- virtual ~GetDirectSettingFunction();
+ ~GetDirectSettingFunction() override;
DISALLOW_COPY_AND_ASSIGN(GetDirectSettingFunction);
};
@@ -54,10 +54,10 @@ class SetDirectSettingFunction : public DirectSettingFunctionBase {
protected:
// ExtensionFunction:
- virtual bool RunSync() override;
+ bool RunSync() override;
private:
- virtual ~SetDirectSettingFunction();
+ ~SetDirectSettingFunction() override;
DISALLOW_COPY_AND_ASSIGN(SetDirectSettingFunction);
};
@@ -70,10 +70,10 @@ class ClearDirectSettingFunction : public DirectSettingFunctionBase {
protected:
// ExtensionFunction:
- virtual bool RunSync() override;
+ bool RunSync() override;
private:
- virtual ~ClearDirectSettingFunction();
+ ~ClearDirectSettingFunction() override;
DISALLOW_COPY_AND_ASSIGN(ClearDirectSettingFunction);
};

Powered by Google App Engine
This is Rietveld 408576698