chrome/browser/extensions/user_script_loader.h - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/user_script_loader.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/user_script_listener_unittest.cc ('k') | chrome/browser/extensions/user_script_loader_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/user_script_loader.h

diff --git a/chrome/browser/extensions/user_script_loader.h b/chrome/browser/extensions/user_script_loader.h

index 85d1bb1618c7db9f18ab0c113713141d2dc15f11..687bd9c3144aea81f1bc20cca7531a2fb0cdc7fb 100644

--- a/chrome/browser/extensions/user_script_loader.h

+++ b/chrome/browser/extensions/user_script_loader.h

@@ -59,7 +59,7 @@ class UserScriptLoader : public content::NotificationObserver,

UserScriptLoader(Profile* profile,

const ExtensionId& owner_extension_id,

bool listen_for_extension_system_loaded);

- virtual ~UserScriptLoader();

+ ~UserScriptLoader() override;

// Add |scripts| to the set of scripts managed by this loader.

void AddScripts(const std::set<UserScript>& scripts);

@@ -78,15 +78,14 @@ class UserScriptLoader : public content::NotificationObserver,

private:

// content::NotificationObserver implementation.

- virtual void Observe(int type,

- const content::NotificationSource& source,

- const content::NotificationDetails& details) override;

+ void Observe(int type,

+ const content::NotificationSource& source,

+ const content::NotificationDetails& details) override;

// ExtensionRegistryObserver implementation.

- virtual void OnExtensionUnloaded(

- content::BrowserContext* browser_context,

- const Extension* extension,

- UnloadedExtensionInfo::Reason reason) override;

+ void OnExtensionUnloaded(content::BrowserContext* browser_context,

+ const Extension* extension,

+ UnloadedExtensionInfo::Reason reason) override;

// Initiates script load when we have been waiting for the extension system

// to be ready.