Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2316)

Unified Diff: chrome/browser/extensions/user_script_listener_unittest.cc

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/user_script_listener.cc ('k') | chrome/browser/extensions/user_script_loader.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/user_script_listener_unittest.cc
diff --git a/chrome/browser/extensions/user_script_listener_unittest.cc b/chrome/browser/extensions/user_script_listener_unittest.cc
index b5f616dc7c95aff424568a8c83d48bf1ef928ca7..9f4b0f5b126e4e91281ab1ee48033c2877edd8aa 100644
--- a/chrome/browser/extensions/user_script_listener_unittest.cc
+++ b/chrome/browser/extensions/user_script_listener_unittest.cc
@@ -48,18 +48,10 @@ class ThrottleController : public base::SupportsUserData::Data,
}
// ResourceController implementation:
- virtual void Resume() override {
- request_->Start();
- }
- virtual void Cancel() override {
- NOTREACHED();
- }
- virtual void CancelAndIgnore() override {
- NOTREACHED();
- }
- virtual void CancelWithError(int error_code) override {
- NOTREACHED();
- }
+ void Resume() override { request_->Start(); }
+ void Cancel() override { NOTREACHED(); }
+ void CancelAndIgnore() override { NOTREACHED(); }
+ void CancelWithError(int error_code) override { NOTREACHED(); }
private:
net::URLRequest* request_;
@@ -78,7 +70,7 @@ class SimpleTestJob : public net::URLRequestTestJob {
kTestData,
true) {}
private:
- virtual ~SimpleTestJob() {}
+ ~SimpleTestJob() override {}
};
// Yoinked from extension_manifest_unittest.cc.
@@ -109,10 +101,10 @@ class SimpleTestJobURLRequestInterceptor
: public net::URLRequestInterceptor {
public:
SimpleTestJobURLRequestInterceptor() {}
- virtual ~SimpleTestJobURLRequestInterceptor() {}
+ ~SimpleTestJobURLRequestInterceptor() override {}
// net::URLRequestJobFactory::ProtocolHandler
- virtual net::URLRequestJob* MaybeInterceptRequest(
+ net::URLRequestJob* MaybeInterceptRequest(
net::URLRequest* request,
net::NetworkDelegate* network_delegate) const override {
return new SimpleTestJob(request, network_delegate);
« no previous file with comments | « chrome/browser/extensions/user_script_listener.cc ('k') | chrome/browser/extensions/user_script_loader.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698