chrome/browser/extensions/api/preference/preference_apitest.cc - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/preference/preference_apitest.cc

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/preference/preference_api_prefs_unittest.cc ('k') | chrome/browser/extensions/api/preferences_private/preferences_private_api.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/preference/preference_apitest.cc

diff --git a/chrome/browser/extensions/api/preference/preference_apitest.cc b/chrome/browser/extensions/api/preference/preference_apitest.cc

index 4f58d936fd18caf44fa78c7f92bd2021abcca262..aefb8548a2c454b28a7541b86da1d70857f10cbf 100644

--- a/chrome/browser/extensions/api/preference/preference_apitest.cc

+++ b/chrome/browser/extensions/api/preference/preference_apitest.cc

@@ -69,7 +69,7 @@ class ExtensionPreferenceApiTest : public ExtensionApiTest {

EXPECT_FALSE(prefs->GetBoolean(prefs::kSearchSuggestEnabled));

}

- virtual void SetUpOnMainThread() override {

+ void SetUpOnMainThread() override {

ExtensionApiTest::SetUpOnMainThread();

// The browser might get closed later (and therefore be destroyed), so we

@@ -82,7 +82,7 @@ class ExtensionPreferenceApiTest : public ExtensionApiTest {

g_browser_process->AddRefModule();

}

- virtual void TearDownOnMainThread() override {

+ void TearDownOnMainThread() override {

// ReleaseBrowserProcessModule() needs to be called in a message loop, so we

// post a task to do it, then run the message loop.

base::MessageLoop::current()->PostTask(